Skip to content

Example synchronized serializing producer+subscription to #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldaley merged 1 commit into from
Apr 15, 2015
Merged

Example synchronized serializing producer+subscription to #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
110 changes: 110 additions & 0 deletions ...eactive-streams/src/main/java/rx/internal/reactivestreams/RxJavaSynchronizedProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,110 @@
/**
* Copyright 2014 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package rx.internal.reactivestreams;

import java.util.*;

import org.reactivestreams.Subscription;

public final class RxJavaSynchronizedProducer implements rx.Producer, rx.Subscription {
private final Subscription subscription;
private volatile boolean unsubscribed;
/** Guarded by this. */
private boolean emitting;
/** Guarded by this. */
private List<Long> requests;

public RxJavaSynchronizedProducer(Subscription subscription) {
if (subscription == null) {
throw new NullPointerException("subscription");
}
this.subscription = subscription;
}
@Override
public boolean isUnsubscribed() {
return unsubscribed;
}
@Override
public void request(long n) {
if (n > 0 && !unsubscribed) {
synchronized (this) {
if (unsubscribed) {
return;
}
if (emitting) {
if (requests == null) {
requests = new ArrayList<Long>(4);
}
requests.add(n);
return;
}
emitting = true;
}
boolean skipFinal = false;
try {
subscription.request(n);
for (;;) {
List<Long> list;
synchronized (this) {
list = requests;
requests = null;
if (list == null) {
emitting = false;
skipFinal = true;
return;
}
}
for (Long v : list) {
if (v.longValue() == 0L) {
unsubscribed = true;
subscription.cancel();
skipFinal = true;
return;
} else {
subscription.request(v);
}
}
}
} finally {
if (!skipFinal) {
synchronized (this) {
emitting = false;
}
}
}
}
}
@Override
public void unsubscribe() {
if (!unsubscribed) {
synchronized (this) {
if (unsubscribed) {
return;
}
if (emitting) {
// replace all pending requests with this single cancel indicator
requests = new ArrayList<Long>(4);
requests.add(0L);
return;
}
emitting = true;
}
unsubscribed = true;
subscription.cancel();
// no need to leave emitting as this is a terminal state
}
}
}
25 changes: 5 additions & 20 deletions rxjava-reactive-streams/src/main/java/rx/internal/reactivestreams/SubscriberAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,10 @@
*/
package rx.internal.reactivestreams;

import org.reactivestreams.Subscriber;
import org.reactivestreams.Subscription;
import rx.Producer;
import rx.functions.Action0;
import rx.subscriptions.Subscriptions;

import java.util.concurrent.atomic.AtomicBoolean;

import org.reactivestreams.*;

public class SubscriberAdapter<T> implements Subscriber<T> {

private final rx.Subscriber<? super T> rxSubscriber;
Expand All @@ -39,21 +35,10 @@ public void onSubscribe(final Subscription rsSubscription) {
}

if (started.compareAndSet(false, true)) {
rxSubscriber.add(Subscriptions.create(new Action0() {
@Override
public void call() {
rsSubscription.cancel();
}
}));
RxJavaSynchronizedProducer sp = new RxJavaSynchronizedProducer(rsSubscription);
rxSubscriber.add(sp);
rxSubscriber.onStart();
rxSubscriber.setProducer(new Producer() {
@Override
public void request(long n) {
if (n > 0) {
rsSubscription.request(n);
}
}
});
rxSubscriber.setProducer(sp);
} else {
rsSubscription.cancel();
}
Expand Down