3.x: Move Gradle properties into gradle.properties file - #7260
Merged
akarnokd merged 2 commits intoMay 7, 2021
Merged
Conversation
Moved version, group, and description into gradle.properties file. Removed POM_ARTIFACT property as the 'name' property in the settings file is used when building the POM. Removed 'release.scope' property as it does not appear to be used. Removed VERSION_NAME property and references to it, in favor of 'version' property.
Contributor
Author
|
Also verified that the POM created does not change. Generated POM before changes and diff'd it with POM after changes. The POMs are identical. |
Codecov Report
@@ Coverage Diff @@
## 3.x #7260 +/- ##
============================================
- Coverage 99.56% 99.55% -0.02%
Complexity 6757 6757
============================================
Files 747 747
Lines 47391 47391
Branches 6382 6382
============================================
- Hits 47186 47180 -6
- Misses 93 97 +4
- Partials 112 114 +2 Continue to review full report at Codecov.
|
Member
|
Removing some of the properties might break the release plugin: https://github.com/vanniktech/gradle-maven-publish-plugin#setting-properties |
Added POM_ARTIFACT_ID=rxjava in gradle.properties file
Contributor
Author
|
Replaced property for release plugin. |
Contributor
Author
|
VERSION_NAME and GROUP default to 'version' and 'group' as seen on Line 9 and 10 from Plugin source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved version, group, and description into gradle.properties file.
Removed POM_ARTIFACT property as the 'name' property in the settings file
is used when building the POM. Removed 'release.scope' property as it
does not appear to be used. Removed VERSION_NAME property and references
to it, in favor of 'version' property.