3.x: Remove Javadoc not failing on error - #7258
Conversation
The 'javadoc' task should fail when there is an error. The 'javadocCleanup' task failed for PR 7239 due to a plugin issue 242, while it should have been the 'javadoc' task that failed the build. Also, publishing when javadocs fail is not desired.
Codecov Report
@@ Coverage Diff @@
## 3.x #7258 +/- ##
============================================
- Coverage 99.57% 99.53% -0.04%
Complexity 6758 6758
============================================
Files 747 747
Lines 47391 47391
Branches 6382 6382
============================================
- Hits 47190 47172 -18
- Misses 91 97 +6
- Partials 110 122 +12 Continue to review full report at Codecov.
|
|
If I understand correctly, #7239 would override the JDK that compiles and tests RxJava to be 8 always. This is not desired because the purpose of the JDK 11 build is to verify the fix of #7173, which needs an actual JDK 11 runtime. We don't care about the Javadoc generated for the JDK 11 build, only the build of JDK 8. |
|
Thanks for giving that history. I'll have to think through it now that I understand it. I think that this pull request is valuable and independent of that though. Correct? |
|
Were you implying that the Javadoc task for JDK 11 Workflow the was added in the previous pull request should be removed? That would make sense |
I think it was disabled because pre-Java 8 javadoc generation sometimes failed even though it managed to do its job. Let's have this PR.
Let it be for now. |
2 participants
The 'javadoc' task should fail when there is an error. The
'javadocCleanup' task failed for PR 7239 due to publish plugin issue 242,
while it should have been the 'javadoc' task that failed the build.
Also, publishing when javadocs fail is not desired.