2.x: WIP removes anonymous inner classes. - #5174
Merged
akarnokd merged 5 commits intoMar 11, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 2.x #5174 +/- ##
===========================================
- Coverage 96% 95.96% -0.04%
+ Complexity 5663 5654 -9
===========================================
Files 621 621
Lines 39974 40247 +273
Branches 5610 5610
===========================================
+ Hits 38378 38625 +247
- Misses 630 649 +19
- Partials 966 973 +7
Continue to review full report at Codecov.
|
akarnokd
reviewed
Mar 11, 2017
| throw ExceptionHelper.wrapOrThrow(NotificationLite.getError(buf)); | ||
| } | ||
| return NotificationLite.getValue(buf); | ||
| private class Iterator implements java.util.Iterator<T> { |
| return true; | ||
| } | ||
|
|
||
| private final class RemoveFromBuffer implements Runnable { |
| } | ||
| } | ||
|
|
||
| private final class SingletonArrayFunc implements Function<T, R> { |
| w.dispose(); | ||
| } | ||
|
|
||
| private final class OnNext implements Runnable { |
| } | ||
| } | ||
|
|
||
| private class OnError implements Runnable { |
| dispose(); | ||
| } | ||
|
|
||
| private final class TimeoutTask implements Runnable { |
| } | ||
| } | ||
|
|
||
| private final class Cancellation implements Runnable { |
| } | ||
| } | ||
|
|
||
| private final class Completion implements Runnable { |
| } | ||
| } | ||
|
|
||
| private final class FlowableWithLatestSubscriber<U> implements FlowableSubscriber<U> { |
| } | ||
| } | ||
|
|
||
| private final class SingletonArrayFunc implements Function<T, R> { |
akarnokd
reviewed
Mar 11, 2017
akarnokd
left a comment
akarnokd
left a comment
Member
There was a problem hiding this comment.
A couple of places still require attention.
| other.subscribe(otherSubscriber); | ||
| } | ||
|
|
||
| private final class DelaySubscriber implements FlowableSubscriber<U> { |
| main.subscribe(new OnCompleteSubscriber()); | ||
| } | ||
|
|
||
| private class DelaySubscription implements Subscription { |
| co.connect(new DisposableConsumer(srw)); | ||
| } | ||
|
|
||
| private final class DisposableConsumer implements Consumer<Disposable> { |
akarnokd
changed the title
Contributor
Author
|
@akarnokd on it |
SleimanJneidi
changed the title
akarnokd
reviewed
Mar 11, 2017
akarnokd
left a comment
akarnokd
left a comment
Member
There was a problem hiding this comment.
Still two missing. Look at the main page where there should be a bunch of collapsed comment along with the remaining problems in FlowableDelay.
| } | ||
| } | ||
|
|
||
| private class OnError implements Runnable { |
| } | ||
| } | ||
|
|
||
| private class OnComplete implements Runnable { |
Member
|
Great job! I'll merge this so the changes don't get too numerous. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP. Since the changes are big, an incremental review and PR was recommended by @akarnokd