fix: use plain boolean for ECS control-flow flags - #231
Merged
Conversation
droguljic
force-pushed
the
fix/ecs-plain-boolean
branch
from
May 31, 2026 07:13
78ce36a to
351836d
Compare
bornast
approved these changes
Jun 1, 2026
Previously, EcsService wrapped boolean flags that control branching logic in `pulumi.Input<boolean>`. This caused a subtle bug where a dynamic `false` value would be treated as truthy (a resolved Output object), incorrectly enabling a feature instead of disabling it. All control-flow flags are now plain `boolean` types to ensure values are evaluated directly and predictably.
droguljic
force-pushed
the
fix/ecs-plain-boolean
branch
from
June 2, 2026 11:22
351836d to
e94580f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, EcsService wrapped boolean flags that control branching logic in
pulumi.Input<boolean>. This caused a subtle bug where a dynamicfalsevalue would be treated as truthy (a resolved Output object), incorrectly enabling a feature instead of disabling it.All control-flow flags are now plain
booleantypes to ensure values are evaluated directly and predictably.Depends on: #229