Skip to content

MAINT: Upgrade software stack#292

Merged
mmcky merged 5 commits into
mainfrom
maint-04oct
Oct 11, 2023
Merged

MAINT: Upgrade software stack#292
mmcky merged 5 commits into
mainfrom
maint-04oct

Conversation

@mmcky

@mmcky mmcky commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

This PR upgrades to:

  • anaconda==2023.09
  • python=3.11
  • quantecon-book-theme==0.6.0

@mmcky

mmcky commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

@HumphreyYang would you have time to look into this link checker result?

@github-actions

github-actions Bot commented Oct 4, 2023

Copy link
Copy Markdown

@github-actions github-actions Bot temporarily deployed to pull request October 4, 2023 00:45 Inactive
@mmcky mmcky changed the title MAINT: Upgrade to python=3.11 and anaconda==2023.09 MAINT: Upgrade software stack Oct 4, 2023
@HumphreyYang HumphreyYang reopened this Oct 4, 2023
@mmcky

mmcky commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author
  • re-run without cache

@HumphreyYang

HumphreyYang commented Oct 4, 2023

Copy link
Copy Markdown
Member

Many thanks @mmcky,

The link checker is all green now.

@mmcky

mmcky commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

thanks @HumphreyYang love your work.

@mmcky

mmcky commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author
  • re-enable the build cache

@mmcky mmcky mentioned this pull request Oct 4, 2023
@github-actions github-actions Bot temporarily deployed to pull request October 4, 2023 01:17 Inactive
@mmcky

mmcky commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

@HumphreyYang @HengchengZhang if you had 10minutes would you mind to look through the latest deployment and let me know if you spot any issues or regressions.

@HengchengZhang

Copy link
Copy Markdown
Member

Hi Matt, the new search bar and the dark mode looks all good to me.

One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?

It is still great if we use the current theme.

@mmcky

mmcky commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

Hi Matt, the new search bar and the dark mode looks all good to me.

One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?

It is still great if we use the current theme.

Thanks @HengchengZhang -- I agree we need to make improvements to the theme. Are you indicating that quantecon-book-theme==0.6.0 is worse than our current live site which uses quantecon-book-theme==0.5.3?

@HengchengZhang

Copy link
Copy Markdown
Member

Hi Matt, the new search bar and the dark mode looks all good to me.
One minor thing I can mention is that the color of code block in dark mode, they are now the same color as in bright mode with a dark background. I think it would be better to have a seperate color map for that if possible?
It is still great if we use the current theme.

Thanks @HengchengZhang -- I agree we need to make improvements to the theme. Are you indicating that quantecon-book-theme==0.6.0 is worse than our current live site which uses quantecon-book-theme==0.5.3?

Hi @mmcky I think the new quantecon-book-theme==0.6.0 is better than current site but the code part can be improved. But still the new theme is pretty nice.

@mmcky

mmcky commented Oct 11, 2023

Copy link
Copy Markdown
Contributor Author

thanks @HumphreyYang and @HengchengZhang for your review and comments.

Upgrading to the latest versions now.

@mmcky mmcky merged commit 2c15456 into main Oct 11, 2023
@mmcky mmcky deleted the maint-04oct branch October 11, 2023 03:23
@github-actions github-actions Bot temporarily deployed to pull request October 11, 2023 03:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants