Skip to content

Reject non-finite decimal.Decimal query parameters (NaN, sNaN, ±Infinity) #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 2 commits into from
May 15, 2026
+17 −0
Merged

Reject non-finite decimal.Decimal query parameters (NaN, sNaN, ±Infinity) #1237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3e7a7e
Initial plan
Copilot May 15, 2026
5331d4b
Reject non-finite Decimal query parameters
Copilot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pymysql/converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ def escape_struct_time(obj, mapping=None):


def Decimal2Literal(o, d):
if not o.is_finite():
raise ProgrammingError("%s can not be used with MySQL" % str(o).lower())
return format(o, "f")


Expand Down
15 changes: 15 additions & 0 deletions pymysql/tests/test_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import datetime
from decimal import Decimal
from unittest import TestCase
from pymysql import converters
from pymysql.err import ProgrammingError


__all__ = ["TestConverter"]
Expand Down Expand Up @@ -52,3 +54,16 @@ def test_convert_time_with_fsp(self):
expected = datetime.time(23, 6, 20, 511581)
time_obj = converters.convert_time("23:06:20.511581")
self.assertEqual(time_obj, expected)

def test_decimal_special_values(self):
values = (
Decimal("NaN"),
Decimal("sNaN"),
Decimal("Infinity"),
Decimal("-Infinity"),
)
for value in values:
with self.assertRaisesRegex(
ProgrammingError, f"{str(value).lower()} can not be used with MySQL"
):
converters.Decimal2Literal(value, None)
Loading