Reject non-finite decimal.Decimal query parameters (NaN, sNaN, ±Infinity)#1237
Merged
Conversation
Agent-Logs-Url: https://github.com/PyMySQL/PyMySQL/sessions/03a4da50-2324-4c73-9ae2-a96583c3d334 Co-authored-by: methane <[email protected]>
Copilot
AI
changed the title
[WIP] Fix decimal.Decimal handling for NaN and Infinity
Reject non-finite May 15, 2026
decimal.Decimal query parameters (NaN, sNaN, ±Infinity)
methane
approved these changes
May 15, 2026
methane
pushed a commit
that referenced
this pull request
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyMySQL already rejects non-finite
floatparameters before sending SQL, but equivalentdecimal.Decimalvalues were still serialized and sent. This change aligns Decimal behavior with existing float safeguards for unsupported non-finite numeric parameters.Converter behavior
pymysql.converters.Decimal2Literalto reject non-finiteDecimalvalues viaDecimal.is_finite().ProgrammingErrorwith the same message pattern already used for float ("<value> can not be used with MySQL"), normalized to lowercase.Targeted test coverage
pymysql/tests/test_converters.pyfor:Decimal("NaN")Decimal("sNaN")Decimal("Infinity")Decimal("-Infinity")ProgrammingErroris raised during literal conversion.Example