Expose SQLSTATE on MySQL protocol exceptions without changing exception formatting#1236
Merged
Conversation
Agent-Logs-Url: https://github.com/PyMySQL/PyMySQL/sessions/08427ad4-5a0d-4c7e-a271-9934e091607c Co-authored-by: methane <[email protected]>
Copilot
AI
changed the title
[WIP] Fix sqlstate handling in error exceptions
Expose SQLSTATE on MySQL protocol exceptions without changing exception formatting
May 15, 2026
methane
reviewed
May 15, 2026
Agent-Logs-Url: https://github.com/PyMySQL/PyMySQL/sessions/915978f1-7ae1-4f3d-afa3-f1f3718b6200 Co-authored-by: methane <[email protected]>
methane
approved these changes
May 15, 2026
methane
pushed a commit
that referenced
this pull request
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL ERR packets can include a 5-byte SQLSTATE, but PyMySQL currently drops it when raising exceptions. This change preserves that protocol metadata on the exception object while keeping the existing exception args and string representation stable.
Error packet parsing
pymysql.err.raise_mysql_exception().Exception surface
exc.sqlstate.exc.argsunchanged as(errno, message)to avoid breaking existing callers that depend on current formatting/tuple shape.sqlstatetoNonewhen the server packet does not include it.Focused coverage
Example: