Skip to content

Support MySQL 8 row/column alias syntax in executemany INSERT regex #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 5 commits into from
May 14, 2026
+30 −2
Merged

Support MySQL 8 row/column alias syntax in executemany INSERT regex #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e4c10ca
Initial plan
Copilot May 14, 2026
f08726f
Support INSERT alias syntax in executemany regex
Copilot May 14, 2026
2b75b42
Refine executemany regex with alias support and compatibility
Copilot May 14, 2026
f9fc93d
Harden alias identifier matching in executemany regex
Copilot May 14, 2026
68e84fb
uv format
methane May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pymysql/cursors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,11 @@
#: You can use it to load large dataset.
RE_INSERT_VALUES = re.compile(
r"\s*((?:INSERT|REPLACE)\b.+\bVALUES?\s*)"
+ r"(\(\s*(?:%s|%\(.+\)s)\s*(?:,\s*(?:%s|%\(.+\)s)\s*)*\))"
+ r"(\s*(?:ON DUPLICATE.*)?);?\s*\Z",
+ r"(\(\s*(?:%s|%\([^)]+\)s)\s*(?:,\s*(?:%s|%\([^)]+\)s)\s*)*\))"
+ r'(\s*(?:AS\s+(?:`[^`]+`|"[^"]+"|[0-9A-Za-z_$]+)\s*'
+ r'(?:\(\s*(?:`[^`]+`|"[^"]+"|[0-9A-Za-z_$]+)\s*'
+ r'(?:,\s*(?:`[^`]+`|"[^"]+"|[0-9A-Za-z_$]+)\s*)*\))?\s*)?'
+ r"(?:ON DUPLICATE.*)?);?\s*\Z",
re.IGNORECASE | re.DOTALL,
)

Expand Down
25 changes: 25 additions & 0 deletions pymysql/tests/test_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,31 @@
import pytest


def test_re_insert_values_with_on_duplicate_key_alias():
m = pymysql.cursors.RE_INSERT_VALUES.match(
"INSERT INTO t1 (a,b,c) VALUES (%s,%s,%s) AS new "
"ON DUPLICATE KEY UPDATE c = new.a + new.b"
)
assert m is not None
assert m.group(1) == "INSERT INTO t1 (a,b,c) VALUES "
assert m.group(2) == "(%s,%s,%s)"
assert m.group(3) == " AS new ON DUPLICATE KEY UPDATE c = new.a + new.b"

m = pymysql.cursors.RE_INSERT_VALUES.match(
"INSERT INTO t1 (a,b,c) VALUES (%s,%s,%s) AS new(n1,n2,n3) "
"ON DUPLICATE KEY UPDATE c = n1 + n2"
)
assert m is not None
assert m.group(3) == " AS new(n1,n2,n3) ON DUPLICATE KEY UPDATE c = n1 + n2"

m = pymysql.cursors.RE_INSERT_VALUES.match(
"INSERT INTO t1 (a,b,c) VALUES (%s,%s,%s) "
"ON DUPLICATE KEY UPDATE c=VALUES(a)+VALUES(b)"
)
assert m is not None
assert m.group(3) == " ON DUPLICATE KEY UPDATE c=VALUES(a)+VALUES(b)"


class CursorTest(base.PyMySQLTestCase):
def setUp(self):
super().setUp()
Expand Down
Loading