Skip to content

Permission for publication of PyMySQL stubs in typeshed #524

Closed
Closed
Permission for publication of PyMySQL stubs in typeshed#524

Description

@jhagerer
jhagerer
opened on Oct 26, 2016

I started to generate stubs for PyMySQL, which I uploaded to this repo.

I want to commit all this as third party stubs to the typeshed repo as I stated it in an issue there. According to the guidelines of typeshed and PEP484 respectively, the official permission from the regarding project for which the stubs are generated is necessary.

So, does the PyMySQL project agree that stubs generated for this project are published as third party stubs as part of the typeshed project?

Thanks in advance!

Activity

  1. methane commented on Oct 26, 2016

    @methane
    methane
    on Oct 26, 2016
    Member

    Thanks, go ahead!

    One point:
    https://github.com/ghagerer/pymysql_stubs/blob/master/__init__.pyi#L30-L33

    def Connect(*args, **kwargs) -> Connection: ...
def get_client_info() -> str: ...

connect = ...  # type: Any

    connect should be defined as function which signature is same to Connect.
    Connect is only for backward compatibility. connect is standard (defined in DB-API 2.0) API.

  2. jhagerer commented on Oct 26, 2016

    @jhagerer
    jhagerer
    on Oct 26, 2016
    Author

    Thanks! I included your feedback in the code.

  3. methane
    closed this as completedon Jan 12, 2017
  4. github-actions
    locked as resolved and limited conversation to collaborators on Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions