Skip to content

Request API preview when asking for labels - #1102

Closed
phako wants to merge 1 commit into
PyGithub:masterfrom
phako:master
Closed

Request API preview when asking for labels#1102
phako wants to merge 1 commit into
PyGithub:masterfrom
phako:master

Conversation

@phako

@phako phako commented Apr 25, 2019

Copy link
Copy Markdown

Pass preview "Access" headers for label descriptions when requesting

Fixes the first part of #1101

@sfdye

sfdye commented Apr 25, 2019

Copy link
Copy Markdown
Member

Thanks, please fix the unit test.

@phako

phako commented Apr 26, 2019

Copy link
Copy Markdown
Author

Is there any quick way to add the missing headers or should i run python -m tests --record (Which seems to add a load of other headers as well)

@sfdye

sfdye commented Apr 27, 2019

Copy link
Copy Markdown
Member

This should help:
https://github.com/PyGithub/PyGithub/blob/master/CONTRIBUTING.md#automated-tests

More headers is fine, as long as the tests can pass.

@stale

stale Bot commented Jun 26, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants