Skip to content

Initial Commit - #2

Closed
AdrianMachado wants to merge 7 commits into
masterfrom
new_site
Closed

Initial Commit#2
AdrianMachado wants to merge 7 commits into
masterfrom
new_site

Conversation

@AdrianMachado

Copy link
Copy Markdown
Member

New design, layout, updated information

New design, layout, updated information
@AdrianMachado

Copy link
Copy Markdown
Member Author

Email must be created, fonts must be updated to match logo

Comment thread README.md Outdated
@@ -1,2 +1,26 @@
# projectreflect.github.io
Organization Website
# [Start Bootstrap](http://startbootstrap.com/) - [Grayscale](http://startbootstrap.com/template-overviews/grayscale/)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix readme pls

@Alexander-Wen

Copy link
Copy Markdown
Member

image

Is there anyway to vertically center this, and invert the image so it doesnt look so weird.

@timmui

timmui commented Feb 8, 2016

Copy link
Copy Markdown
Member

i agree with @Alexander-Wen, also can we find another cover image? I really don't like the Made in USA, because this isn't

Comment thread index.html Outdated
<title>Reflect - The Smart Mirror</title>

<!-- Bootstrap Core CSS -->
<link href="css/bootstrap.min.css" rel="stylesheet">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a CDN, lets not host ourself, it bloats our repo

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Converted to CDN for source CSS and fonts, removed unneeded maps code
Comment thread README.md Outdated


## Creator
The Reflect website was created, and is maintained by Adrian.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really necessary?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super necessary, will remove if you want.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a creator on any other repo

@Alexander-Wen

Copy link
Copy Markdown
Member

image
nice job on the inverse! i like it, but is there anyway to vertically center it? or is that too difficult

@AdrianMachado

Copy link
Copy Markdown
Member Author

I am still trying to figure out how to do the vertical centering without affecting the other elements in the nav bar

@Alexander-Wen

Copy link
Copy Markdown
Member

if its too much of a hassle now, its fine. Just raise an issue on github so we remember to deal with it later.

@Alexander-Wen

Copy link
Copy Markdown
Member

This is just personal preference and you don't have to do this if you don't want to, but can you squash your commits into 1 to make the git tree more tidy

Cleaning up JS, removing unecessary code, converting to CDN
Fixed spacing issue near the bottom of the page
@timmui

timmui commented Feb 8, 2016

Copy link
Copy Markdown
Member

Just add bottom padding or margin to that element or negative padding/margin to the top

Comment thread index.html Outdated
<div class="col-lg-8 col-lg-offset-2">
<h2>Contact Us</h2>
<p>Feel free to email us to provide some feedback on Reflect, give us suggestions for new features and widgets, or to just say hello!</p>
<p><a href="mailto:[email protected]">[email protected]</a>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mailto is wrong

Site title and mailto changed
@AdrianMachado

Copy link
Copy Markdown
Member Author

No one does yet though, we should grab a domain soon anyways, since we are putting this site up

@timmui

timmui commented Feb 8, 2016

Copy link
Copy Markdown
Member

Doesn't make sense to have a contact email that doesn't exist

@timmui

timmui commented Feb 8, 2016

Copy link
Copy Markdown
Member

Also, vertical spacing of nav bar logo still off and I think a sans-serif body font makes more sense when you have a serif title font

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants