feat(sql-utilities): support multiple SELECT projections with single aggregate#362
Merged
milindsrivastava1997 merged 2 commits intoMay 24, 2026
Conversation
milindsrivastava1997
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Relax the projection parser to support standard grouped-aggregate SQL forms such as:
Previously, the parser required
projection.len() == 1, causing these queries to fall through todestination=none_unsupported.Changes
Walk the full projection list instead of requiring a single projection item
Allow:
Require every non-aggregate identifier in
SELECTto also appear inGROUP BY, matching standard SQL semanticsThis prevents cases like:
from being silently interpreted as if
srcipwere never requested.Still Unsupported
The parser continues to reject:
*)The structural pattern model still supports only a single aggregate statistic.
Tests Added
Added 8 parser tests covering:
group columns followed by aggregate
aggregate-first ordering
ClickHouse parametric quantile in multi-projection form
structural equivalence between single- and multi-projection queries
SELECTsubset ofGROUP BYrejection of:
GROUP BYidentifiers