Conversation
PrestaShop 9.2 removes install/ itself at the end of the installation (Install::finalize() logs "The install/ folder was removed."). docker_run.sh runs under set -e and then called rm -r on the folder that is gone, so a successful auto-install ended with "rm: cannot remove '/var/www/html/install/'" and the container exited before starting Apache. Remove it only when it is still there, so older versions keep the same behaviour and a failure to remove it still stops the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrestaShop 9.2 removes
install/itself at the end of the installation (Install::finalize()logs "The install/ folder was removed.").docker_run.shruns underset -eand then callsrm -ron that folder, so a successful auto-install ends with:and the container exits with code 1 before Apache starts.
The folder is now removed only when it is still there. Versions that leave it behind keep the current behaviour, and a failure to remove it still stops the script. The change is the same in
base/config_files/docker_run.shand in the 20 generated copies.Tested with
prestashop/prestashop:9.2.0-6.0-rc.1-classic-8.4-apache,PS_INSTALL_AUTO=1,PS_FOLDER_ADMIN=admin123, with this script mounted as/tmp/docker_run.sh: the install completes, the web server starts, the front office answers 200 and the back office 302. That run also needs PrestaShop/PrestaShop#42639: RC1 stops earlier, infinalize(), onassets:install admin-devwhen the admin folder was renamed before the installer ran, which this image does.