Repository navigation
Clear vulnerable transitive packages in test project; update CI - #8
Merged
Merged
Conversation
The test project pulled System.Net.Http 4.3.0 and System.Text.RegularExpressions 4.3.0 (both High severity advisories) through old xunit and FakeItEasy versions. Moves the test project to net8.0 with current test packages, and updates CI to the .NET 8 SDK and actions/checkout@v4. The published library still targets net6.0.
Contributor
Author
🔍 QA report: ✅ PassedTested at commit The PR does what it says. The test project moves to net8.0 with newer test packages, and CI and release use the .NET 8 SDK with checkout v4. All 7 tests pass, and the vulnerability scan is clean for both projects. I found no proof-worthy problems.
🧪 Commands run
🔦 Worth a human look
📂 Files reviewed2 of 2 changed code files opened by QA (from its tool calls) · 2 code files with no test Each file
📸 ScreenshotsNo screenshots were taken during this review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet list package --vulnerable --include-transitiveflagged two High severity advisories, both in the test project only (not the published package):Both came in through NETStandard.Library 1.6.1 via xunit 2.4.2 and FakeItEasy 7.4.0.
Changes:
The library itself still targets net6.0 and its packages are unchanged; it scans clean.
Verified locally: vulnerability scan is clean for both projects, and all 7 tests pass.