Skip to content

Misc Fixes (followup to #387) - #396

Merged
vexx32 merged 1 commit into
mainfrom
misc-fixes
Jun 14, 2020
Merged

vexx32 merged 1 commit into
mainfrom
misc-fixes

Conversation

@vexx32

@vexx32 vexx32 commented Jun 14, 2020 •

Copy link
Copy Markdown
Collaborator

PR Summary

Small updates and fixes on top of #387 to address unresolved review comments.

Context

Changes

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added the Category-Koans Invoking the Great Doubt label Jun 14, 2020
@vexx32
vexx32 requested a review from steviecoaster as a code owner June 14, 2020 02:46
@vexx32 vexx32 added the PR-Needs-Review 🔍 Let's take a closer look! label Jun 14, 2020
@vexx32 vexx32 closed this Jun 14, 2020
@vexx32 vexx32 reopened this Jun 14, 2020
@vexx32 vexx32 closed this Jun 14, 2020
@vexx32 vexx32 reopened this Jun 14, 2020
@vexx32
vexx32 merged commit f81479b into main Jun 14, 2020
@vexx32
vexx32 deleted the misc-fixes branch June 14, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant