Skip to content

Adjust typos, parameters, remove unused lines in AboutCsvCmdlets.Koans.ps1 - #390

Merged
vexx32 merged 2 commits into
PowerShellOrg:masterfrom
johnheusinger:issue389
May 19, 2020
Merged

vexx32 merged 2 commits into
PowerShellOrg:masterfrom
johnheusinger:issue389

Conversation

@johnheusinger

@johnheusinger johnheusinger commented May 18, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

Resolves #389

Context

Made some adjustments to help with issues I had while working through the koan. Fixed typos and parameters, removed unused lines.

Changes

  • Removed references to $Letters and $PipeDelimitedCsvPath which were defined but never used
  • Replaced GetType() with GetType().FullName - The former returns an object, not a string, so the Pester tests would always fail
  • Replaced two instances of Should -NotBeNullOrEmpty with Should -Not -BeNullOrEmpty
  • Issue with failing test due to $CsvString containing type information. Resolved by adding -NoTypeInformation to ConvertTo-Csv

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels May 19, 2020

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing these! 💖 😊

@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label May 19, 2020
@vexx32
vexx32 merged commit e40c60a into PowerShellOrg:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with AboutCsvCmdlets.Koans.ps1

2 participants