Skip to content

fixed some pester scoping issues and validation issues - #388

Merged
vexx32 merged 4 commits into
PowerShellOrg:masterfrom
natebru:master
May 19, 2020
Merged

vexx32 merged 4 commits into
PowerShellOrg:masterfrom
natebru:master

Conversation

@natebru

@natebru natebru commented May 14, 2020 •

Copy link
Copy Markdown
Contributor

PR Summary

Context

Goal is to improve functionality and clean up some pester related scoping issues

Changes

  • Fixed parenthesis issue for 2 pester tests
  • fixed pester scope issue
  • added line return to help clarity

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these! There's one point we'll need to figure something else out for, but the rest look good. Nice work! 😊 💖

Comment thread PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated
@vexx32 vexx32 added the Category-Koans Invoking the Great Doubt label May 14, 2020
Comment thread PSKoans/Koans/Constructs and Patterns/AboutRegularExpressions.Koans.ps1 Outdated
@vexx32 vexx32 added the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label May 19, 2020

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks so much! 😊 💖

@vexx32 vexx32 removed the PR-Awaiting-Author ✏️ Waiting on a response from the user who submitted the PR. label May 19, 2020
@vexx32
vexx32 merged commit 1bb29d7 into PowerShellOrg:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants