Skip to content

Add missing $array variable to It block in AboutArrays Koan - #385

Merged
vexx32 merged 1 commit into
PowerShellOrg:masterfrom
the-cashman:master
Apr 22, 2020
Merged

vexx32 merged 1 commit into
PowerShellOrg:masterfrom
the-cashman:master

Conversation

@the-cashman

Copy link
Copy Markdown
Contributor

There is a missing $array variable assignment in one of the array koan tests. The test will always fail unless you provide a value for $array.

Noticed while practicing the Koans.

Updates AboutArrays.Koans.ps1

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for fixing this! 😊 💖

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt Issue-Bug 🐛 Something's wrong! and removed Issue-Bug 🐛 Something's wrong! labels Apr 22, 2020
@vexx32
vexx32 merged commit 8dcd4e8 into PowerShellOrg:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants