fixes problematic assertions in AboutPSObjects - #381
Merged
Merged
Conversation
missing sorting in AboutPSObject.Koans.ps1 might deem a test a failure even if the answers were correct, but in the wrong order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes problematic assertions in AboutPSObjects
PR Summary
missing sorting in AboutPSObject.Koans.ps1 might deem a test a failure
even if the answers were correct, but in the wrong order
Fixes #366
Context
The intention here is to sort the property names from $Object.PSObject.Properties to ensure the property names are always in the same order
Changes
At all spots were the reference value was sorted, a Sort-Object was added for the difference value.
Checklist