Skip to content

fixes problematic assertions in AboutPSObjects - #381

Merged
vexx32 merged 1 commit into
PowerShellOrg:masterfrom
Maamue:master
Mar 21, 2020
Merged

vexx32 merged 1 commit into
PowerShellOrg:masterfrom
Maamue:master

Conversation

@Maamue

@Maamue Maamue commented Mar 21, 2020

Copy link
Copy Markdown
Contributor

fixes problematic assertions in AboutPSObjects

PR Summary

missing sorting in AboutPSObject.Koans.ps1 might deem a test a failure
even if the answers were correct, but in the wrong order

Fixes #366

Context

The intention here is to sort the property names from $Object.PSObject.Properties to ensure the property names are always in the same order

Changes

At all spots were the reference value was sorted, a Sort-Object was added for the difference value.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

missing sorting in AboutPSObject.Koans.ps1 might deem a test a failure
even if the answers were correct, but in the wrong order
@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Mar 21, 2020

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for taking care of this! 💖 😊

@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Mar 21, 2020
@vexx32
vexx32 merged commit 6d5fcb6 into PowerShellOrg:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue in AboutPSObjects

2 participants