Skip to content

(#372) AboutEnumerations: Use Version-Appropriate TryParse() Method - #374

Merged
vexx32 merged 1 commit into
masterfrom
AboutEnumerations/FixTryParse
Mar 8, 2020
Merged

vexx32 merged 1 commit into
masterfrom
AboutEnumerations/FixTryParse

Conversation

@vexx32

@vexx32 vexx32 commented Mar 8, 2020 •

Copy link
Copy Markdown
Collaborator

PR Summary

The overload used is only available in .NET Core; add a branch checking the version to select the appropriate method.

Context

Resolves #372

Changes

  • Add a version check so we can pick the appropriate method.
  • Add some commentary to explain the choice of method.

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Koans Invoking the Great Doubt labels Mar 8, 2020
@vexx32
vexx32 requested a review from steviecoaster as a code owner March 8, 2020 01:54
@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Mar 8, 2020
@vexx32
vexx32 merged commit 1f58ac5 into master Mar 8, 2020
@vexx32
vexx32 deleted the AboutEnumerations/FixTryParse branch March 8, 2020 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with AboutEnumeration

1 participant