(#372) Fix issues in AboutEnumeration - #373
Merged
Merged
Conversation
Refactor slightly, match file more to current style. Rename a few tests to make more sense.
We can test file ASTs during our static analysis checks. Added a test to check we don't have any nested It blocks in the file.
Using a raw scriptblock will break the parser in earlier versions. Fix is to define it as a string and parse that just before execution.
vexx32
added
PR-Needs-Review 🔍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixed a few issues in the
AboutEnumerationstopic and added a regression test to catch nestedItblocks in future (which aren't legal Pester syntax anyway).Context
Partial fix for #372
Changes
Checklist