(#298) Refactor Show-Advice Tests by vexx32 · Pull Request #361 · PowerShellOrg/PSKoans

vexx32 · 2020-02-27T00:19:03Z

PR Summary

Use mocks instead of modifying the filesystem & use test cases instead of manual for loops.

Resolves #298

Move malformed JSON tests to a new Context
Mock Get-Content and Get-ChildItem so that we can just return the JSON without editing files on the hard drive
Use TestCases to go through the different variants of invalid json rather than a for loop.

Pull Request has a meaningful title.
Summarised changes.
Pull Request is ready to merge & is not WIP.
Added tests / only testable interactively.
- Make sure you add a new test if old tests do not effectively test the code changed.
Added documentation / opened issue to track adding documentation at a later date.

Use mocks instead of directly modifying the filesystem. Also use test cases instead of manual for loops.

✅ Refactor Show-Advice tests

528486c

Use mocks instead of directly modifying the filesystem. Also use test cases instead of manual for loops.

vexx32 added PR-Needs-Review 🔍 Let's take a closer look! Category-Tests ✅ Pertaining to tests for the module functions. labels Feb 27, 2020

vexx32 requested a review from steviecoaster as a code owner February 27, 2020 00:19

vexx32 merged commit 78637a0 into master Feb 27, 2020

vexx32 deleted the Tests/Show-Advice/MockFileAccess branch February 27, 2020 00:33

vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Feb 27, 2020