Skip to content

Added a comment with further explanation for rounding - #357

Merged
vexx32 merged 2 commits into
PowerShellOrg:masterfrom
jschpp:fix-352
Feb 4, 2020
Merged

vexx32 merged 2 commits into
PowerShellOrg:masterfrom
jschpp:fix-352

Conversation

@jschpp

@jschpp jschpp commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Added comment to further detail rounding in Powershell.

Resolves #352

Context

See #352

Changes

  • Added comment

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Feb 3, 2020

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks a lot clearer, thank you! 😊

I have some small suggestions on the specific wording but that's mostly me being picky as all heck 😁

Comment thread PSKoans/Koans/Introduction/AboutNumbers.Koans.ps1 Outdated
Comment thread PSKoans/Koans/Introduction/AboutNumbers.Koans.ps1 Outdated
Comment thread PSKoans/Koans/Introduction/AboutNumbers.Koans.ps1 Outdated
@jschpp
jschpp requested a review from vexx32 February 4, 2020 10:21
@vexx32
vexx32 merged commit a68479b into PowerShellOrg:master Feb 4, 2020
@vexx32

vexx32 commented Feb 4, 2020 •

Copy link
Copy Markdown
Collaborator

Thanks for your contribution @jschpp! 💖 😊

@jschpp
jschpp deleted the fix-352 branch February 5, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more explanation for banker's rounding in AboutNumbers

2 participants