Skip to content

Use integers instead of strings in the -gt and -lt within the AboutComparison Koan - #356

Merged
vexx32 merged 1 commit into
PowerShellOrg:masterfrom
jschpp:fix-String-Comparison-#353
Jan 29, 2020
Merged

vexx32 merged 1 commit into
PowerShellOrg:masterfrom
jschpp:fix-String-Comparison-#353

Conversation

@jschpp

@jschpp jschpp commented Jan 29, 2020

Copy link
Copy Markdown
Contributor

PR Summary

This PR should fix the misunderstanding described in #353

Context

See #353

Changes

  • Replaced array of strings with array of int
  • Added $NewArray to hold answer

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@vexx32 vexx32 added Category-Koans Invoking the Great Doubt PR-Needs-Review 🔍 Let's take a closer look! labels Jan 29, 2020

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much clearer. Thank you! 😊 💖

@vexx32 vexx32 removed the PR-Needs-Review 🔍 Let's take a closer look! label Jan 29, 2020
@vexx32
vexx32 merged commit 840b69f into PowerShellOrg:master Jan 29, 2020
@jschpp
jschpp deleted the fix-String-Comparison-#353 branch January 29, 2020 14:18
@jschpp jschpp mentioned this pull request Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants