Add "Open File" Feature - #346
Conversation
vexx32
added
PR-Needs-Review 🔍
a9198c6 to
dc4ba7f
Compare
- Move `-Meditate` to open the current file - Add `-Library` to open the folder.
When Get-PSKoan is called with the user scope it needs to check if the folder actually exists.
- Use temp dir in show-karma test - Restructure tests to avoid duplication
fa5c876 to
d44205d
Compare
steviecoaster
left a comment
steviecoaster
left a comment
There was a problem hiding this comment.
This looks OK to me, provided the default option in the switch for picking an editor allows for powershell ise for folks still beholden to it?
|
@steviecoaster yeah, PS ISE doesn't support a great deal of flexibility really, all it supports as far as I could find is a file path argument, much like most other editors will. We can always add new ones and reevaluate the solution as we go if we need to ^^ |
|
@vexx32 Hi Joel, sorry for the long delay, I've been super busy lately, and since I didn't have much experience with Pester I needed time to fix the tests. anyway, I'm happy you guys picked it up, I'm going to do the PSKoans test from the start and I'll let you know if I find any problem. 😊 |
|
@arefg not a problem! Hopefully everything works as expected! I'm looking to get this and other recent changes packed into a new release soon. 😊💖 |
3 participants
PR Summary
Add functionality for opening current koan file instead of just the overall PSKoanLocation from
Show-KarmaContext
This PR supersedes #317, all credit for initial idea goes to @arefg -- thank you so much for the work you put in on this already, it really made this a hundred times easier. 😊 💖
Changes
-Libraryswitch.-Contemplateswitch to work as an "open current file in the set editor" with capability to recognisecodeandcode-insidersas well asatomand pass correct arguments for these editors to also go to the relevant line in the file.Checklist