Skip to content

🐛 AboutAssignmentAndArithmetic - Fix assertions so they aren't already true - #323

Merged
vexx32 merged 1 commit into
PowerShellOrg:masterfrom
jessiewestlake:patch-3
Nov 7, 2019
Merged

🐛 AboutAssignmentAndArithmetic - Fix assertions so they aren't already true#323
vexx32 merged 1 commit into
PowerShellOrg:masterfrom
jessiewestlake:patch-3

Conversation

@jessiewestlake

@jessiewestlake jessiewestlake commented Nov 7, 2019 •
edited by vexx32
Loading

Copy link
Copy Markdown
Contributor

Two of the tests were already true, so it showed progress already being complete.
Converted those two tests to be consistent with the others in the same section.

# PR Summary

Context

Changes

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

@jessiewestlake
🐛 Fix assertion so it isn't already true
d64498a 
Two of the tests were already true, so it showed progress already being complete.
Converted those two tests to be consistent with the others in the same section.
vexx32
vexx32 approved these changes Nov 7, 2019
View reviewed changes

@vexx32 vexx32 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! 😊💖🌸

@vexx32 vexx32 added the Category-Koans Invoking the Great Doubt label Nov 7, 2019
@vexx32
vexx32 merged commit 010e361 into PowerShellOrg:master Nov 7, 2019
@vexx32 vexx32 changed the title 🐛 Fix assertions so they aren't already true 🐛 AboutAssignmentsAndArithmetic - Fix assertions so they aren't already true Nov 9, 2019
@vexx32 vexx32 changed the title 🐛 AboutAssignmentsAndArithmetic - Fix assertions so they aren't already true 🐛 AboutAssignmentAndArithmetic - Fix assertions so they aren't already true Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vexx32 vexx32 vexx32 approved these changes
@steviecoaster steviecoaster Awaiting requested review from steviecoaster

Assignees

No one assigned

Labels

Category-Koans Invoking the Great Doubt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jessiewestlake @vexx32