Conversation
vexx32
added
Category-Module
vexx32
left a comment
vexx32
left a comment
There was a problem hiding this comment.
I love this idea! I've been toying with it for a while, but this is the first time I've had a look at the code that might be able to do it.
I think we can do this a little more neatly, but this is on the right track overall! 💖 😊
vexx32
added
PR-Awaiting-Author ✏️
Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
vexx32
added
PR-Needs-Review 🔍
vexx32
left a comment
vexx32
left a comment
There was a problem hiding this comment.
Awesome! I think we're getting pretty close here, that looks pretty good. One minor concern with the platform selection and then just mainly style comments for the switch statement. 🙂
Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
vexx32
added
PR-Awaiting-Author ✏️
vexx32
left a comment
vexx32
left a comment
There was a problem hiding this comment.
Fantastic!
Thank you so much! Appreciate all your patience on this, I know I can be a bit picky. 😊 💖
|
Hey Joel, I know this is a stupid question 😄 but since I'm new to all these Github stuff, what should I do now? Should I click on "Close and comment"? 😛 |
vexx32
left a comment
vexx32
left a comment
There was a problem hiding this comment.
Last minor thing and then you'll just need to update the tests to expect this behaviour so they stop failing. 🙂 💖
|
@arefg once you update the tests and everything in the CI is green I'll merge the PR, no worries :) |
Co-Authored-By: Joel Sallow (/u/ta11ow) <[email protected]>
|
I'll continue this in #346 for now. Thanks for the great work so far! 😊 💖 |
vexx32
removed
the
PR-Awaiting-Author ✏️
2 participants
I think it would be a good idea to have a parameter for Show-Karma cmdlet to be able to not only open the PSKoans directory but also jump to the failing topic and the exact line on that file.
I've added a parameter named OpenFile with an alias (Continue), this parameter uses the $Results.Meditation to extract the path and line number of the failing topic.
Maybe there is a better way of extracting the file path and achieving the same result (by RegEx or other means) but it's working great for VS Code and I think we can change it a little bit to detect the PowerShell ISE and at least open the failing topic file or at best jump to the failing line as well.
With this, we can continue our journey of enlightenment 😄 by just typing:
Show-Karma -Continue