No need for package sources - #803
Merged
TylerLeonhardt merged 1 commit intoDec 1, 2018
Merged
Conversation
TylerLeonhardt
requested review from
Patrick Meinecke (SeeminglyScience) and
Keith Hill (rkeithhill)
November 30, 2018 04:34
Contributor
|
Tangentially related, but I found out today PS modules can also be obtained with nuget. See https://github.com/PowerShell/PowerShell/pull/8350/files. |
Member
Author
|
Yeah the Gallery is just another nuget repository so that does work... Still requires reaching into the nuget cache and grabbing stuff out of it which isn't pretty |
Member
Author
|
I personally don't think that's worth it just so we can use a csproj to list dependencies. |
Rob Holt (rjmholt)
approved these changes
Nov 30, 2018
Rob Holt (rjmholt)
left a comment
Rob Holt (rjmholt)
left a comment
Contributor
There was a problem hiding this comment.
Aditya Patwardhan (@adityapatwardhan) Talked me through this so I understand it, so it LGTM now!
Keith Hill (rkeithhill)
approved these changes
Nov 30, 2018
Keith Hill (rkeithhill)
left a comment
Keith Hill (rkeithhill)
left a comment
Contributor
There was a problem hiding this comment.
I approve but this is not my area of expertise. So take my approval with that caveat. :-)
TylerLeonhardt
added a commit
to TylerLeonhardt/PowerShellEditorServices
that referenced
this pull request
Dec 14, 2018
Rob Holt (rjmholt)
pushed a commit
to rjmholt/PowerShellEditorServices
that referenced
this pull request
Jan 18, 2019
Rob Holt (rjmholt)
pushed a commit
to rjmholt/PowerShellEditorServices
that referenced
this pull request
Jan 18, 2019
[Ignore] no need for package sources (PowerShell#803) [Ignore] add null check for version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE THIS IS GOING INTO 2.0.0
These sources aren't needed because now that 2.0.0 pulls in PSStandard, it can fetch it from nuget.org which is the default.
And I don't think we need the dotnet-core one.
Also, as a result of this change, I can successfully build PSES offline finally 😄
Keith Hill (@rkeithhill) do you know if we need the disableSourceControlIntegration at all? We could possibly get rid of this file all together.