Skip to content

Resolves PackageManagement builds on FullCLR and CoreCLR#962

Closed
dgrala wants to merge 7 commits intomasterfrom
darek
Closed

Resolves PackageManagement builds on FullCLR and CoreCLR#962
dgrala wants to merge 7 commits intomasterfrom
darek

Conversation

@dgrala
Copy link
Copy Markdown

@dgrala dgrala commented May 6, 2016

No description provided.

@andyleejordan
Copy link
Copy Markdown
Member

@dgrala I rebased your branch onto andschwa/package-management-files after rebasing it onto master. This should now be up-to-date with the latest sources.

@andyleejordan
Copy link
Copy Markdown
Member

I also amended your last commit so that it doesn't erroneously update the Pester module.

@andyleejordan
Copy link
Copy Markdown
Member

andyleejordan commented May 6, 2016

And pulled in Microsoft.PackageManagement/project.json as it originally wasn't added in a separate commit from the Source Depot import. <-- my bad rebase

@andyleejordan
Copy link
Copy Markdown
Member

Now unfortunately, I think .NET CLI's Windows builds just broke on us. Give me a minute.

@andyleejordan
Copy link
Copy Markdown
Member

I pinned the version of .NET CLI in #963 and reported it upstream; it shouldn't have broken like that.

@andyleejordan
Copy link
Copy Markdown
Member

I also need to fix up your project.json dependencies; there are a lot of extras.

@andyleejordan
Copy link
Copy Markdown
Member

@dgrala The projects restore and and the code is here... but now the question is, what is the top-level PackageManagement project that the host should take a dependency on so that this gets built?

@andyleejordan andyleejordan mentioned this pull request May 18, 2016
2 tasks
@andyleejordan
Copy link
Copy Markdown
Member

Closing with #991.

@vors vors restored the darek branch June 22, 2016 03:33
@vors vors deleted the darek branch June 22, 2016 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants