Skip to content

Batch merge builds together while a merge build is running - #8668

Merged
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
TravisEz13:batch_merge_builds
Jan 16, 2019
Merged

Batch merge builds together while a merge build is running#8668
Travis Plunk (TravisEz13) merged 1 commit into
PowerShell:masterfrom
TravisEz13:batch_merge_builds

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Jan 16, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Batch merge builds together while a merge build is running

PR Context

Help keep agents available for CI runs.

PR Checklist

@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Jan 16, 2019

Copy link
Copy Markdown
Member

Missing Linux yml

@TravisEz13
Travis Plunk (TravisEz13) merged commit 4d69997 into PowerShell:master Jan 16, 2019
@TravisEz13
Travis Plunk (TravisEz13) deleted the batch_merge_builds branch January 16, 2019 23:29
@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 17, 2019
@iSazonov

Ilya (iSazonov) commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

Travis Plunk (@TravisEz13) Could you please add more info about benefits of the change for my education?

@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) See here:

https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=vsts&tabs=yaml#continuous-integration-ci

I could be missing some nuances also, but it appears that they're looking to batch together builds that originate from the same PR in order to allow Azure to queue a batch job if someone pushes a bunch of commits in quick succession; it will simply build them as one, shortening the overall build time. 🙂

@iSazonov

Ilya (iSazonov) commented Jan 17, 2019

Copy link
Copy Markdown
Collaborator

Rain Sallow (/u/ta11ow) (@vexx32) Thanks. I still don't understand how it works really.

@TravisEz13

Travis Plunk (TravisEz13) commented Jan 17, 2019

Copy link
Copy Markdown
Member Author

This does not batch PR builds. This batches merge (or as Azure DevOps calls them CI builds) while a merge build is in progress.

So if we merge PR A and a merge build starts.

Then we merge PR B and C while the build for PR A is still running, the next build will build B & C.

The feature Rain Sallow (/u/ta11ow) (@vexx32) mentioned is on by default.

@iSazonov

Ilya (iSazonov) commented Jan 18, 2019

Copy link
Copy Markdown
Collaborator

Thanks Travis Plunk (@TravisEz13) !

@vexx32

Rain Sallow (/u/ta11ow) (vexx32) commented Jan 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Appreciate the clarification, looks like I gotta brush up on the yml spec once again! 😄

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@TravisEz13
Batch merge builds together while a merge build is running (PowerShel…
9e2399a 
…l#8668)

## PR Summary

Batch merge builds together while a merge build is running 

## PR Context  

Help keep agents available for CI runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) adityapatwardhan approved these changes
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Assignees

No one assigned

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

4 participants

@TravisEz13 @adityapatwardhan @iSazonov @vexx32