Skip to content

docs(contributing): add link check information - #8659

Merged
Travis Plunk (TravisEz13) merged 12 commits into
PowerShell:masterfrom
RDIL:patch-2
Jan 16, 2019
Merged

docs(contributing): add link check information#8659
Travis Plunk (TravisEz13) merged 12 commits into
PowerShell:masterfrom
RDIL:patch-2

Conversation

@RDIL

@RDIL Reece Dunham (RDIL) commented Jan 16, 2019

Copy link
Copy Markdown
Contributor

PR Summary

title

PR Context

Travis Plunk (@TravisEz13) told me to do this
Travis if your reading this just know I have to update the other file please no merge yet

PR Checklist

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
@RDIL Reece Dunham (RDIL) changed the title [ WIP ] docs(contributing): add link check information docs(contributing): add link check information Jan 16, 2019
@RDIL

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) feedback addressed, Travis Plunk (@TravisEz13) ready for review.

Comment thread .github/CONTRIBUTING.md Outdated
Comment thread .github/CONTRIBUTING.md Outdated
@RDIL

Copy link
Copy Markdown
Contributor Author

Aditya Patwardhan (@adityapatwardhan) please re-review since requested changes were addressed.

Comment thread .github/CONTRIBUTING.md
Comment thread .github/CONTRIBUTING.md
* if the `.spelling` file is updated, commit and push it

#### Checking links in documentation
Documentation is link-checked. We make use of the

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest saying that this and markdown syntax checking (like the newline before and after headers.) can be checked by running start-pspester -includecommontests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread .github/CONTRIBUTING.md
Comment thread .github/CONTRIBUTING.md
#### Spellchecking documentation

Documentation are spellchecked. We make use of the
Documentation is spellchecked. We use the

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file apparently isn't being checked for markdown syntax issues.
You can add it by updating this list

'./.github/CONTRIBUTING.md'
'./*.md'
'./demos/python/*.md'
'./docker/*.md'
'./docs/*.md'
'./docs/building/*.md'
'./docs/cmdlet-example/*.md'
'./docs/maintainers/*.md'
'./docs/testing-guidelines/testing-guidelines.md'
'./test/powershell/README.md'
'./tools/*.md'

Not a requirement. If you are using, vscode, you can just install the markdownlinq extension and you should get the issues as well.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay 👍

@TravisEz13

Copy link
Copy Markdown
Member

Thanks a lot.

@TravisEz13 Travis Plunk (TravisEz13) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Jan 16, 2019
@TravisEz13
Travis Plunk (TravisEz13) merged commit 9eb6fc9 into PowerShell:master Jan 16, 2019
@RDIL
Reece Dunham (RDIL) deleted the patch-2 branch January 16, 2019 23:35
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants