Skip to content

Style: Change Char to char and Boolean to bool - #8572

Merged
Dongbo Wang (daxian-dbw) merged 10 commits into
PowerShell:masterfrom
iSazonov:style-char-alias
Jan 7, 2019
Merged

Style: Change Char to char and Boolean to bool#8572
Dongbo Wang (daxian-dbw) merged 10 commits into
PowerShell:masterfrom
iSazonov:style-char-alias

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Dec 31, 2018 •
edited
Loading

Copy link
Copy Markdown
Collaborator

PR Summary

Change Char to char and Boolean to bool.

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 31, 2018
@iSazonov
Ilya (iSazonov) force-pushed the style-char-alias branch 5 times, most recently from 7291bf1 to c6384ed Compare December 31, 2018 20:50
@iSazonov Ilya (iSazonov) changed the title Style: Change Char to char and Boolean to boolean Style: Change Char to char and Boolean to bool Dec 31, 2018
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Jan 6, 2019
View reviewed changes
Comment thread src/System.Management.Automation/engine/interpreter/CallInstruction.Generated.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/NumericConvertInstruction.cs Outdated
Comment thread src/System.Management.Automation/engine/interpreter/Utilities.cs Outdated
@iSazonov

Ilya (iSazonov) commented Jan 6, 2019

Copy link
Copy Markdown
Collaborator Author

Dongbo Wang (@daxian-dbw) Your comments is addressed and the merge conflict is resolved.

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jan 7, 2019
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jan 7, 2019

Copy link
Copy Markdown
Member

There is another conflict after merging your 'String-to-string' PR. Can you please resolve this one too?

@iSazonov

Ilya (iSazonov) commented Jan 7, 2019

Copy link
Copy Markdown
Collaborator Author

Done.

daxian-dbw
Dongbo Wang (daxian-dbw) approved these changes Jan 7, 2019
View reviewed changes

@daxian-dbw Dongbo Wang (daxian-dbw) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit f95dae5 into PowerShell:master Jan 7, 2019
@iSazonov
Ilya (iSazonov) deleted the style-char-alias branch January 7, 2019 19:44
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@iSazonov @daxian-dbw
Style: Use the type aliases 'char' and 'bool' instead of 'Char' and '…
ca2daac 
…Boolean' (PowerShell#8572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay
@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
@PaulHigin Paul Higinbotham (PaulHigin) Awaiting requested review from PaulHigin

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iSazonov @daxian-dbw