Fix typo in AMSI test - #8561
Conversation
Ilya (iSazonov)
added
the
CL-CodeCleanup
|
|
||
| $EICAR_STRING_B64 = "awZ8EmMWc3JjaAdvY2lrBgcbY20aBHBwGgROF3Z6cHJhHmBncn13cmF3HnJ9Z3plemFmYB5ndmBnHnV6f3YSF3sYexk= " | ||
| $bytes = [System.Convert]::FromBase64String($EICAR_STRING_B64) | ||
| $EICAR_STRING = -join ($bytes | ForeEach-Object { [char]($_ -bxor 0x33) }) |
There was a problem hiding this comment.
The issue isn't the use of alias or not; the issue is that the cmdlet name was misspelled (ForeEach-Object should be ForEach-Object). I think removing the alias was the right move; we should keep the proper full cmdlet name.
Why did this not come up in the initial PR?
There was a problem hiding this comment.
Thanks! I'll try cmdlet name. In initial PR we did not run all tests with [Feature].
There was a problem hiding this comment.
Seems like we should be able to detect that the change is within a Feature test and automatically run those, let me think about this.
There was a problem hiding this comment.
CoreFX team uses a bot to run tests. We could do the same.
Perhaps it makes sense to run short set of tests initially for speed. Then always run full set of tests before merge.
There was a problem hiding this comment.
Ilya (@iSazonov) that's a good idea. Maintainers can request bot to run full set of tests after review is approved and CI tests pass. Let me work on this.
|
Steve Lee (@SteveL-MSFT) Please review to fix night tests. |
3 participants
PR Summary
Now CI-Windows fail after #8546 : correct typo in cmdlet name in AMSI test.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests