Remove use of cmdlet aliases from .\test\powershell - #8546

xtqqczze Thanks for your contribution!

We never used message suppressions and I would delete its. In the case we could fast merge. If you think that this could be useful please open new issue for discussion.

xtqqczze Sorry, I meant that comments is not needed too. We don't have strong CI checks for scripts. So such suppressions and related comments makes no sense.

Ilya (@iSazonov) When using vscode with the ms-vscode.powershell extension enabled, rule violations from PSScriptAnalyzer testing are listed as warnings in the 'Problems' pane, for example:

{
	"resource": "~/test/powershell/Modules/Microsoft.PowerShell.Utility/Set-Variable.Tests.ps1",
	"owner": "_generated_diagnostic_collection_name_#2",
	"code": "PSAvoidUsingCmdletAliases",
	"severity": 4,
	"message": "'sv' is an alias of 'Set-Variable'. Alias can introduce possible problems and make scripts hard to maintain. Please consider changing alias to its full content.",
	"source": "PSScriptAnalyzer",
	"startLineNumber": 178,
	"startColumn": 2,
	"endLineNumber": 178,
	"endColumn": 4
}

Certain tests have comments explaining a rule should be ignored, because at the present time rules can only be suppressed on a file level for Pester tests. These comments help identify spurious warnings in the vscode 'Problems' pane and provide a placeholder for future implementation of rule suppression at a test level.

xtqqczze I see your point. These comments is obvious and don't add value but reduce readability. Your proposal will be useful after we (1) get implementation of local suppressions and (2) force CIs. Today I suggest split replacing aliases and suppressing messages. For second work you could open a tracking issue if you want.

xtqqczze Thanks for your contribution!