Skip to content

Style: Remove space after new keyword in implicitly typed array allocation - #8505

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
daxian-dbw:spaceInNew
Dec 21, 2018
Merged

Style: Remove space after new keyword in implicitly typed array allocation#8505
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
daxian-dbw:spaceInNew

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Dec 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Remove space after new keyword in implicitly typed array allocation.
654 issues are fixed.

PR Checklist

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 21, 2018
iSazonov
Ilya (iSazonov) approved these changes Dec 21, 2018
View reviewed changes

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dongbo Wang (@daxian-dbw) Recently Jason noted that it makes sense to merge Types_Ps1Xml.cs and TypesV3_Ps1Xml.cs (perhaps some files from FormatAndOutput\DefaultFormatters too). I looked this but there are difficulties for me. The merging may speed up startup.

@iSazonov Ilya (iSazonov) self-assigned this Dec 21, 2018
@iSazonov
Ilya (iSazonov) merged commit e999e1d into PowerShell:master Dec 21, 2018
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the spaceInNew branch December 21, 2018 18:08
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 21, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Ilya (@iSazonov) What do you mean by merging them? Having a single .cs file that contains the type definitions for both? I don't think that alone will affect the perf, so there should be more that Jason wanted.
I did looked at the CPU time trace with the IL assemblies when working on the startup perf, and the huge yield methods in those 2 files does take an outstanding amount of the CPU time, over 2%. But the data is from IL assemblies and thus I'm not sure if it's really an issue with crossgen'ed assemblies. I couldn't generate PDBs for crossgen'ed assemblies.

I haven't contact .NET Core team on the crossgen related issues/questions. I moved to something with higher priority.

@iSazonov

Ilya (iSazonov) commented Dec 21, 2018

Copy link
Copy Markdown
Collaborator

Yes, single file. Jason simply mentioned that now there is no reason to have different files. Thanks for clarification about perf.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 22, 2018

Copy link
Copy Markdown
Member Author

I will get back to those huge yield state-machine methods when switching back to the CPU trace analysis work.

@iSazonov

Ilya (iSazonov) commented Dec 22, 2018

Copy link
Copy Markdown
Collaborator

Perhaps we could get more win by investigating to Jason's PSMore #7857. I guess that definitely yes at startup.

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw @iSazonov
Remove space after new keyword in implicitly typed array allocation (P…
97593be 
…owerShell#8505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daxian-dbw @iSazonov