Update Third Party Notices - #8415
Conversation
Reece Dunham (RDIL)
left a comment
Reece Dunham (RDIL)
left a comment
There was a problem hiding this comment.
Suggestion: add to the head of the html file just for best practices.
|
Reece Dunham (@RDIL) What part of the Head specifically is missing? I can give this feedback to the teams that generates this. <head><title>THIRD PARTY SOFTWARE NOTICES AND INFORMATION</title><style>pre{white-space:pre-wrap;background:#eee;padding:24px}</style></head> |
|
Stuff such as meta tags like (charset, description, etc) (can’t say the raw
tags because I’m on mobile now)
…On Mon, Dec 10, 2018 at 2:32 PM Travis Plunk ***@***.***> wrote:
@RDIL <https://github.com/RDIL> What part of the Head specifically is
missing? I can give this feedback to the teams that generates this.
Existing head section:
<head><title>THIRD PARTY SOFTWARE NOTICES AND INFORMATION</title><style>pre{white-space:pre-wrap;background:#eee;padding:24px}</style></head>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8415 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ag9GdsZs6mysNFwzmOV3zMhFaqpypVqmks5u3rbLgaJpZM4ZHgJA>
.
|
|
Dan Butvinik (@dabutvin) Can you see the feedback about the TPN at #8415 (comment) |
|
The generator we are using here is based on a project from amzn and we should probaly fix the default html template if there are issues with it or improvements to be had. https://github.com/amzn/tiny-attribution-generator/blob/master/default-htmltemplate.hbs#L4-L17 Feel free to open issues and/or PRs over there. Also, after looking at your changes here, if you would prefer to keep the notice file in TXT format there is an option to generate in TXT instead of HTML - there's a new toggle switch on the generator you can switch |
|
Done. |
1b92ebb to
dacff5f
Compare
|
thanks for the heads up that we can generate |
|
Verified license is readable in MSI. |
Reece Dunham (RDIL)
left a comment
Reece Dunham (RDIL)
left a comment
There was a problem hiding this comment.
Gets my approval now even if it means nothing.
|
Travis Plunk (@TravisEz13) What is right |
Travis Plunk (TravisEz13)
added
the
CL-BuildPackaging
|
I believe this fixes #6463 |
Update ThirdPartyNotices - update the TPN in license.rtf - add the additional attributions needed to generate the TPN
7 participants
PR Summary
Update ThirdPartyNotices
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests