Skip to content

Fix EnvironmentVariable test and add missing null check in CommandHelpProvider - #8408

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:testfixes
Dec 11, 2018
Merged

Fix EnvironmentVariable test and add missing null check in CommandHelpProvider#8408
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:testfixes

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Dec 6, 2018

Copy link
Copy Markdown
Member

PR Summary

  • Disable NewItemUnauthorizedAccessError tests.
  • Added expected value for $env:HOMEPATH for user with temporary profile.
  • Added a missing null check in CommandHelpProvider.cs

PR Checklist

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Test fixes and missing null check Fix EnvironmentVariable test and add missing null check in CommandHelpProvider Dec 6, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TravisEz13
Travis Plunk (TravisEz13) merged commit 551ed10 into PowerShell:master Dec 11, 2018
@TravisEz13 Travis Plunk (TravisEz13) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Dec 11, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
…pProvider (PowerShell#8408)

* Disable NewItemUnauthorizedAccessError tests.
* Added expected value for $env:HOMEPATH for user with temporary profile.
* Added a missing null check in CommandHelpProvider.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants