Remove dotnet dependency to start WebListener - #8390
Merged
Travis Plunk (TravisEz13) merged 7 commits intoDec 11, 2018
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
requested review from
Travis Plunk (TravisEz13) and
Mark Kraus (markekraus)
December 4, 2018 00:47
Aditya Patwardhan (adityapatwardhan)
requested review from
Paul Higinbotham (PaulHigin),
Andrew (anmenaga) and
Dongbo Wang (daxian-dbw)
as code owners
December 4, 2018 00:47
Paul Higinbotham (PaulHigin)
suggested changes
Dec 4, 2018
Member
Author
|
Paul Higinbotham (@PaulHigin) Dongbo Wang (@daxian-dbw) Feedback has been addressed, please have another look. |
Paul Higinbotham (PaulHigin)
approved these changes
Dec 4, 2018
Dongbo Wang (daxian-dbw)
approved these changes
Dec 4, 2018
Member
Author
|
Travis Plunk (@TravisEz13) Can this be merged? |
Mark Kraus (markekraus)
approved these changes
Dec 6, 2018
Member
Author
|
Travis Plunk (@TravisEz13) Can this be merged? |
Travis Plunk (TravisEz13)
approved these changes
Dec 11, 2018
Travis Plunk (TravisEz13)
added
the
CL-Test
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
WebListener.exe (which was already being built) is sufficient to start web listener. Remove the dependency on `dotnet` being present to start the web listener. Use `Start-Process` instead of `Start-Job` to launch the WebListener.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
WebListener.exe (which was already being built) is sufficient to start web listener. Remove the dependency on
dotnetbeing present to start the web listener.Use
Start-Processinstead ofStart-Jobto launch the WebListener.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests