Adding yml for Windows Release builds - #8374
Merged
Travis Plunk (TravisEz13) merged 23 commits intoDec 7, 2018
Merged
Conversation
added 18 commits
November 12, 2018 11:59
Andrew (anmenaga)
requested review from
Travis Plunk (TravisEz13) and
Aditya Patwardhan (adityapatwardhan)
November 30, 2018 19:07
Andrew (anmenaga)
requested review from
Paul Higinbotham (PaulHigin) and
Dongbo Wang (daxian-dbw)
as code owners
November 30, 2018 19:07
Aditya Patwardhan (adityapatwardhan)
requested changes
Nov 30, 2018
Author
|
Fixed CodeFactor issues. |
Author
|
Aditya Patwardhan (@adityapatwardhan) pls look again. |
Travis Plunk (TravisEz13)
changed the title
Travis Plunk (TravisEz13)
left a comment
Travis Plunk (TravisEz13)
left a comment
Member
There was a problem hiding this comment.
LGTM other than comments
Travis Plunk (TravisEz13)
approved these changes
Dec 5, 2018
Aditya Patwardhan (adityapatwardhan)
approved these changes
Dec 5, 2018
Aditya Patwardhan (adityapatwardhan)
left a comment
Aditya Patwardhan (adityapatwardhan)
left a comment
Member
There was a problem hiding this comment.
All comments are non-blocking
|
|
||
| - powershell: | | ||
| docker container prune --force | ||
| docker container ls --all --format '{{ json .ID }}' | ConvertFrom-Json | %{docker container rm --force --volumes $_} |
There was a problem hiding this comment.
Change % to ForEach-Object
| condition: and(succeeded(), ne(variables['SkipFxDependent'], 'true')) | ||
|
|
||
| - powershell: | | ||
| docker image ls --format '{{ json .}}'|ConvertFrom-Json|% { |
There was a problem hiding this comment.
Change % to ForEach-Object
|
|
||
| - powershell: | | ||
| docker container prune --force | ||
| docker container ls --all --format '{{ json .ID }}' | ConvertFrom-Json | %{docker container rm --force --volumes $_} |
There was a problem hiding this comment.
Change % to ForEach-Object
| continueOnError: true | ||
|
|
||
| - powershell: | | ||
| docker image ls --format '{{ json .}}'|ConvertFrom-Json|% { |
There was a problem hiding this comment.
Change % to ForEach-Object
Travis Plunk (TravisEz13)
approved these changes
Dec 7, 2018
Travis Plunk (TravisEz13)
added
the
CL-BuildPackaging
Travis Plunk (TravisEz13)
pushed a commit
to TravisEz13/PowerShell
that referenced
this pull request
May 14, 2019
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
As part of improving the build process, the UI build pipeline for Windows Builds was converted to a yml-based pipeline. (everything minus compliance tasks)
Verified on AzureDevOps mirror (pipeline
WIP-PowerShellCore-WindowsBuild-Yaml): automated and manual runs.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests