Skip to content

Added SelfSignedCertificate module to the test package - #8350

Merged
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixTestPackage
Nov 30, 2018
Merged

Added SelfSignedCertificate module to the test package#8350
Aditya Patwardhan (adityapatwardhan) merged 1 commit into
PowerShell:masterfrom
adityapatwardhan:FixTestPackage

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Nov 28, 2018

Copy link
Copy Markdown
Member

PR Summary

The test package is missing the SelfSignedCertificate module, which is downloaded from the gallery. This change adds that module to the appropriate location for packaging.

PR Checklist

@adityapatwardhan

Copy link
Copy Markdown
Member Author

I have verified by running the function New-TestPackage that the module is included.

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread build.psm1 Outdated
@adityapatwardhan

Copy link
Copy Markdown
Member Author

Rob Holt (@rjmholt) can you have another look.

@rjmholt Rob Holt (rjmholt) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TravisEz13

Copy link
Copy Markdown
Member

make sure dependabot detects the new csproj after merging

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 3794a5e into PowerShell:master Nov 30, 2018
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Nov 30, 2018
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants