Cleanup '#if !CORECLR' code - #8337
Merged
Merged
Conversation
Ilya (iSazonov)
requested review from
Steve Lee (SteveL-MSFT) and
Dongbo Wang (daxian-dbw)
November 26, 2018 11:26
Ilya (iSazonov)
requested review from
Bruce Payette (BrucePay),
Paul Higinbotham (PaulHigin),
Andrew (anmenaga) and
Mike Richmond (mirichmo)
as code owners
November 26, 2018 11:26
Ilya (iSazonov)
force-pushed
the
cleanup-corecrl2
branch
from
November 26, 2018 12:52
af4245f to
cc33627
Compare
Ilya (iSazonov)
requested review from
Travis Plunk (TravisEz13) and
Aditya Patwardhan (adityapatwardhan)
as code owners
November 26, 2018 12:52
Travis Plunk (TravisEz13)
approved these changes
Nov 26, 2018
| , RegistryKeyPermissionCheck.ReadWriteSubTree | ||
| #endif | ||
| ); | ||
| Credential_Delegation_Key = rootKey.CreateSubKey(Registry_Path_Credentials_Delegation, RegistryKeyPermissionCheck.ReadWriteSubTree); |
There was a problem hiding this comment.
Why did you decide to add RegistryKeyPermissionCheck parameter here?
It looks like the macro was removing it previously...
Collaborator
Author
There was a problem hiding this comment.
I guess it was removed because CoreFX had not support. Now we have this and we can enable the check.
Steve Lee (SteveL-MSFT)
requested changes
Nov 28, 2018
Ilya (iSazonov)
added
the
CL-CodeCleanup
Steve Lee (SteveL-MSFT)
approved these changes
Nov 30, 2018
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
* NewWinEventCommand.cs * CredSSP.cs * WsManHelper.cs * debugger.cs * InternalHost.cs * InitialSessionState.cs * BaseTransportManager.cs * Types_Ps1Xml.cs * FileSystemProvider.cs * Restore XmlResolver = null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Related #3565 and #4357.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests