Add `Enable-ExperimentalFeature` and `Disable-ExperimentalFeature` cmdlets by SteveL-MSFT · Pull Request #8318 · PowerShell/PowerShell

Steve Lee (SteveL-MSFT) · 2018-11-20T03:48:51Z

PR Summary

Add Enable-ExperimentalFeature and Disable-ExperimentalFeature cmdlets. Remove -ListAvailable from Get-ExperimentalFeature (Breaking Change). Add ArgumentCompleter for Get-ExperimentalFeature cmdlet. Refactor some existing Experimental Feature tests. Make ConfigScope public and renamed SystemWide to AllUsers.

Implements PowerShell/PowerShell-RFC#148

PR Checklist

Rob Holt (rjmholt)

Have left some small comments, but it all looks pretty good to me. We should also make sure we start the documentation process before merging this PR.

Paul Higinbotham (PaulHigin) · 2018-11-20T18:59:39Z

We should write to file only if the features array changes.

Seems like this should be a separate issue for WriteValueToFile(). Opened #8325

Actually, I disagree. We can save even running WriteValueToFile() code, which involves opening the file and reading data, by simply keeping track of whether we actually have a change to record.

Unless we are concerned with file contention. If so, then I assume the last write to should win, and it makes sense to ensure the file actually reflects the current config state.

Paul Higinbotham (PaulHigin)

LGTM

Ilya (iSazonov) · 2018-11-21T03:33:35Z

Can we assign two CL- labels?

Steve Lee (SteveL-MSFT) · 2018-11-28T23:01:07Z

@PowerShell/powershell-committee reviewed this as part of the RFC review and approves of the breaking change and current cmdlet design

add enable/disable-experimentalfeature cmdlets updated existing tests

address CodeFactor issues

fix AppVeyor failure

address Paul and Rob's feedback

Steve Lee (SteveL-MSFT) · 2018-11-30T00:01:01Z

Doc PR submitted and linked

Ilya (iSazonov)

We lost the comment perUserConfigFile -> _perUserConfigFile for private.

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

Ilya (iSazonov)

Steve Lee (@SteveL-MSFT) You skipped two my comments for Should -BeFalse

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

Steve Lee (SteveL-MSFT) · 2018-11-30T17:26:08Z

Ilya (@iSazonov) it was hidden under GitHub collapsing it. Thanks for calling it out. Fixed.

Ilya (iSazonov) · 2018-11-30T19:55:22Z

Steve Lee (@SteveL-MSFT) HelpUri do not pass tests.

Ilya (iSazonov)

It seems we need remove the cmdlets from release versions.

…ableDisableExperimentalFeatureCommand.cs Co-Authored-By: SteveL-MSFT <[email protected]>

address Dongbo's feedback

Dongbo Wang (daxian-dbw) · 2018-12-04T23:36:12Z

Steve Lee (@SteveL-MSFT) One test for Enable/Disable-ExperimentalFeature cmdlets failed in CI runs. Can you please take a look?

Steve Lee (SteveL-MSFT) · 2018-12-05T00:54:06Z

Dongbo Wang (@daxian-dbw) I forgot to update the tests to reflect that the cmdlet no longer outputs the feature object. Will update.

fix tests to reflect that no object is output from cmdlets on success

…dlets (PowerShell#8318) [breaking change] Major changes are as follows: - Add `Enable-ExperimentalFeature` and `Disable-ExperimentalFeature` cmdlets. - Remove `-ListAvailable` from `Get-ExperimentalFeature`. - Add `ArgumentCompleter` for `Get-ExperimentalFeature` cmdlet. - Refactor some existing Experimental Feature tests. - Make `ConfigScope` public and renamed `SystemWide` to `AllUsers`. Also update experimental feature code to prefer the current user config over the all user config.

Steve Lee (SteveL-MSFT) added the Breaking-Change breaking change that may affect users label Nov 20, 2018

Steve Lee (SteveL-MSFT) assigned Dongbo Wang (daxian-dbw) Nov 20, 2018

Steve Lee (SteveL-MSFT) requested review from Paul Higinbotham (PaulHigin) and Dongbo Wang (daxian-dbw) November 20, 2018 03:48

Steve Lee (SteveL-MSFT) requested a review from Bruce Payette (BrucePay) as a code owner November 20, 2018 03:48

Ilya (iSazonov) reviewed Nov 20, 2018

View reviewed changes

Comment thread test/powershell/engine/ExperimentalFeature/EnableDisable-ExperimentalFeature.Tests.ps1 Outdated

Steve Lee (SteveL-MSFT) added the Review - Committee The PR/Issue needs a review from the PowerShell Committee label Nov 20, 2018

Rob Holt (rjmholt) added the Documentation Needed in this repo Documentation is needed in this repo label Nov 20, 2018

Rob Holt (rjmholt) reviewed Nov 20, 2018

View reviewed changes

Paul Higinbotham (PaulHigin) suggested changes Nov 20, 2018

View reviewed changes

Steve Lee (SteveL-MSFT) force-pushed the experimental-feature-cmdlets branch from 808b72b to c8743f3 Compare November 20, 2018 20:41

Paul Higinbotham (PaulHigin) approved these changes Nov 20, 2018

View reviewed changes

Ilya (iSazonov) added CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log CL-Engine Indicates that a PR should be marked as an engine change in the Change Log labels Nov 21, 2018

Joey Aiello (joeyaiello) mentioned this pull request Nov 26, 2018

Draft of experimental feature user experience RFC PowerShell/PowerShell-RFC#148

Merged

Steve Lee (SteveL-MSFT) added Committee-Reviewed PS-Committee has reviewed this and made a decision and removed Review - Committee The PR/Issue needs a review from the PowerShell Committee labels Nov 28, 2018

Steve Lee (SteveL-MSFT) added 3 commits November 29, 2018 13:52

[feature]

8c585f6

add enable/disable-experimentalfeature cmdlets updated existing tests

[feature]

02f566b

address CodeFactor issues

[feature]

6d290b4

fix AppVeyor failure

Steve Lee (SteveL-MSFT) force-pushed the experimental-feature-cmdlets branch from c8743f3 to 4ba6cbc Compare November 29, 2018 21:59

[feature]

6727dd7

address Paul and Rob's feedback

Steve Lee (SteveL-MSFT) force-pushed the experimental-feature-cmdlets branch from 4ba6cbc to 6727dd7 Compare November 29, 2018 22:02

Steve Lee (SteveL-MSFT) removed the Documentation Needed in this repo Documentation is needed in this repo label Nov 29, 2018

Ilya (iSazonov) reviewed Nov 30, 2018

View reviewed changes

Ilya (iSazonov) and others added 2 commits November 29, 2018 21:30

Update test/powershell/engine/ExperimentalFeature/Get-ExperimentalFea…

745a91b

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

Update test/powershell/engine/ExperimentalFeature/Get-ExperimentalFea…

e8218a3

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

Ilya (iSazonov) and others added 4 commits November 29, 2018 21:31

Update test/powershell/engine/ExperimentalFeature/Get-ExperimentalFea…

596afc7

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

Update test/powershell/engine/ExperimentalFeature/Get-ExperimentalFea…

ce871df

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

Update test/powershell/engine/ExperimentalFeature/Get-ExperimentalFea…

7269cf6

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

address Ilya's feedback

903ea39

Ilya (iSazonov) approved these changes Nov 30, 2018

View reviewed changes

Ilya (iSazonov) and others added 2 commits November 30, 2018 09:25

Update test/powershell/engine/ExperimentalFeature/Get-ExperimentalFea…

ecf82cf

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

Update test/powershell/engine/ExperimentalFeature/Get-ExperimentalFea…

890a412

…ture.Tests.ps1 Co-Authored-By: SteveL-MSFT <[email protected]>

add helpuri

3b8d53e

change fwdlink for get-experimentalfeature to original

34e020b

Ilya (iSazonov) reviewed Dec 1, 2018

View reviewed changes

Comment thread ....Management.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs Outdated

Comment thread src/System.Management.Automation/resources/ExperimentalFeatureStrings.resx

Update src/System.Management.Automation/engine/ExperimentalFeature/En…

0508fdd

…ableDisableExperimentalFeatureCommand.cs Co-Authored-By: SteveL-MSFT <[email protected]>

Rain Sallow (/u/ta11ow) (vexx32) reviewed Dec 3, 2018

View reviewed changes

Comment thread ....Management.Automation/engine/ExperimentalFeature/EnableDisableExperimentalFeatureCommand.cs Outdated

Dongbo Wang (daxian-dbw) requested changes Dec 4, 2018

View reviewed changes

Rain Sallow (/u/ta11ow) (vexx32) and others added 2 commits December 4, 2018 14:08

Update src/System.Management.Automation/engine/ExperimentalFeature/En…

8de4efe

…ableDisableExperimentalFeatureCommand.cs Co-Authored-By: SteveL-MSFT <[email protected]>

[feature]

86b56a2

address Dongbo's feedback

Steve Lee (SteveL-MSFT) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan) and Andrew (anmenaga) as code owners December 4, 2018 22:43

Dongbo Wang (daxian-dbw) approved these changes Dec 4, 2018

View reviewed changes

[feature]

93be24e

fix tests to reflect that no object is output from cmdlets on success

Steve Lee (SteveL-MSFT) mentioned this pull request Dec 5, 2018

In PSConfiguration.cs, WriteValueToFile() should check if value has changed before writing #8325

Closed

Dongbo Wang (daxian-dbw) merged commit 52aef57 into PowerShell:master Dec 5, 2018

Dongbo Wang (daxian-dbw) mentioned this pull request Dec 14, 2018

Add about_PowerShell_Config MicrosoftDocs/PowerShell-Docs#3238

Merged

9 tasks

Dongbo Wang (daxian-dbw) mentioned this pull request Feb 20, 2019

Simplify discovering and enabling experimental features #8155

Closed

Steve Lee (SteveL-MSFT) deleted the experimental-feature-cmdlets branch June 6, 2020 02:29

Uh oh!

Conversation

Steve Lee (SteveL-MSFT) commented Nov 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Uh oh!

Rob Holt (rjmholt) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Paul Higinbotham (PaulHigin) Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

Paul Higinbotham (PaulHigin) Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

Paul Higinbotham (PaulHigin) Nov 20, 2018

Choose a reason for hiding this comment

Uh oh!

Paul Higinbotham (PaulHigin) left a comment

Choose a reason for hiding this comment

Uh oh!

Ilya (iSazonov) commented Nov 21, 2018

Uh oh!

Steve Lee (SteveL-MSFT) commented Nov 28, 2018

Uh oh!

Steve Lee (SteveL-MSFT) commented Nov 30, 2018

Uh oh!

Ilya (iSazonov) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) left a comment

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) commented Nov 30, 2018

Uh oh!

Ilya (iSazonov) commented Nov 30, 2018

Uh oh!

Ilya (iSazonov) left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Dongbo Wang (daxian-dbw) commented Dec 4, 2018

Uh oh!

Steve Lee (SteveL-MSFT) commented Dec 5, 2018

Uh oh!

Steve Lee (SteveL-MSFT) commented Nov 20, 2018 •

edited

Loading