Skip to content

Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist - #8305

Merged
Ilya (iSazonov) merged 15 commits into
PowerShell:masterfrom
kvprasoon:fix-8242
Nov 30, 2018
Merged

Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist#8305
Ilya (iSazonov) merged 15 commits into
PowerShell:masterfrom
kvprasoon:fix-8242

Conversation

@kvprasoon

@kvprasoon PRASOON KARUNAN V (kvprasoon) commented Nov 18, 2018

Copy link
Copy Markdown
Contributor

PR Summary

Close #8242

Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist

PR Checklist

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

Comment thread src/Microsoft.PowerShell.Commands.Management/commands/management/Navigation.cs Outdated
@iSazonov

Copy link
Copy Markdown
Collaborator

PRASOON KARUNAN V (@kvprasoon) Please make the PR title more meaningful and add tests.

@kvprasoon PRASOON KARUNAN V (kvprasoon) changed the title Fix for issue 8242 Fix for PSDrive creation with a UNC path with a trailing backslash or forward slash when combined with -Persist Nov 20, 2018
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Outdated
@iSazonov Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 21, 2018
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/PSDrive.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Management/New-PSDrive.Tests.ps1 Outdated
@iSazonov

Copy link
Copy Markdown
Collaborator

PRASOON KARUNAN V (@kvprasoon) Please resolve merge conflicts and address comments.

@kvprasoon

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Done 👍

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iSazonov
Ilya (iSazonov) merged commit 6e523f2 into PowerShell:master Nov 30, 2018
@iSazonov

Copy link
Copy Markdown
Collaborator

PRASOON KARUNAN V (@kvprasoon) Thanks for your contribution!

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New-PSDrive fails with a UNC path with a trailing backslash when combined with -Persist

3 participants