Fix CVE-2018-8415 - #8253
Merged
Travis Plunk (TravisEz13) merged 5 commits intoNov 13, 2018
Merged
Conversation
Travis Plunk (TravisEz13)
requested review from
Bruce Payette (BrucePay) and
Dongbo Wang (daxian-dbw)
as code owners
November 13, 2018 18:10
Travis Plunk (TravisEz13)
requested a review
from Aditya Patwardhan (adityapatwardhan)
November 13, 2018 18:27
Travis Plunk (TravisEz13)
deleted the
security/fix_null_logging_issue_6_1-on-master
branch
November 13, 2018 19:30
Ilya (iSazonov)
added
the
CL-General
Travis Plunk (TravisEz13)
added
CL-Engine
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
If there is a null character in a scriptblock, translate it to a null replacement character before logging with scriptblock logging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix CVE-2018-8415
scriptblock, translate it to a null replacement character before logging withscriptblocklogging.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests