Filter the TestPackage artifact upload by name to avoid other zip files being uploaded - #8116
Conversation
|
I have verified the changes on a private CI run, which is a clone of the official Azure DevOps pipeline. |
Andrew (anmenaga)
left a comment
Andrew (anmenaga)
left a comment
There was a problem hiding this comment.
1 update needed; otherwise looks good.
| # Uploads any packages as an artifact | ||
| - powershell: | | ||
| Get-ChildItem -Path *.pkg, *.tar.gz, *.zip -Recurse | Select-Object -ExpandProperty FullName | ForEach-Object { | ||
| Write-Host "PWD == $pwd" |
There was a problem hiding this comment.
As far as I remember $pwd variable should Not be used in scripts. Change to Get-Location.
There was a problem hiding this comment.
it's likely in this context it's ok, but something that we should be aware of.
James Truher (JamesWTruher)
left a comment
James Truher (JamesWTruher)
left a comment
There was a problem hiding this comment.
my comment isn't blocking
| # Uploads any packages as an artifact | ||
| - powershell: | | ||
| Get-ChildItem -Path *.pkg, *.tar.gz, *.zip -Recurse | Select-Object -ExpandProperty FullName | ForEach-Object { | ||
| Write-Host "PWD == $pwd" |
There was a problem hiding this comment.
it's likely in this context it's ok, but something that we should be aware of.
|
James Truher (@JamesWTruher) Andrew (@anmenaga) Removed the usage of |
|
I will merge when CI passes. |
…es being uploaded (PowerShell#8116)
3 participants
PR Summary
Added logging for
New-TestPackageto make debugging easier.Filter the artifact uploads with the package name instead of *.zip to avoid Help Zip files from being uploaded.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests