Skip to content

Start-Transcript Add option to minimise transcript header - #8402

Merged
Dongbo Wang (daxian-dbw) merged 6 commits into
masterfrom
unknown repository
Dec 20, 2018
Merged

Start-Transcript Add option to minimise transcript header#8402
Dongbo Wang (daxian-dbw) merged 6 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost Deleted user (ghost) commented Dec 5, 2018 •
edited by iSazonov
Loading

Copy link
Copy Markdown

PR Summary

Add a switch parameter UseMinimalHeader to Start-Transcript. When used, a transcript will contain a short header like the following, instead of the usual header containing version information.

**********************
PowerShell transcript start
Start time: 20181201203347
**********************

This partly addresses #8359.

PR Checklist

@iSazonov

Ilya (iSazonov) commented Dec 7, 2018

Copy link
Copy Markdown
Collaborator

@lukexjeremy Thanks for your contribution!
You could look Start-Transcript.Tests.ps1 for tests.

@ghost ghost changed the title WIP: Start-Transcript Add option to minimise transcript header Start-Transcript Add option to minimise transcript header Dec 16, 2018
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Dec 19, 2018
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs Outdated
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs Outdated
Comment thread src/System.Management.Automation/engine/hostifaces/MshHostUserInterface.cs
daxian-dbw
Dongbo Wang (daxian-dbw) requested changes Dec 19, 2018
View reviewed changes
Comment thread src/Microsoft.PowerShell.ConsoleHost/host/msh/StartTranscriptCmdlet.cs Outdated
Comment thread test/powershell/Modules/Microsoft.Powershell.Host/Start-Transcript.Tests.ps1 Outdated
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

@lukexjeremy On another thought, -UseShortHeader might be a better choice as you only have two options: the regular header and the short header, while minimal seems suggesting you have at least 3 options for the header. What do you think?

At the meantime, let me consult with the team members and reply back what they think. Chatted with my teammates offline, and there is a slight preference toward -UseMinimalHeader. So let's stick to that name 😄

@ghost ghost mentioned this pull request Dec 20, 2018
Closed
8 tasks
@daxian-dbw

Dongbo Wang (daxian-dbw) commented Dec 20, 2018

Copy link
Copy Markdown
Member

@lukexjeremy Thank you for opening the doc issue. I forgot that myself :)

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 56fc426 into PowerShell:master Dec 20, 2018
@sdwheeler Sean Wheeler (sdwheeler) mentioned this pull request Dec 21, 2018
Merged
9 tasks
@ghost
ghost deleted the transcript-minimalheader branch December 21, 2018 22:45
@PaulHigin Paul Higinbotham (PaulHigin) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 24, 2019
@ghost ghost mentioned this pull request Apr 13, 2019
Closed
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@lukej57 @daxian-dbw
Add -UseMinimalHeader to Start-Transcript to minimize transcript …
7f6461f 
…header (PowerShell#8402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@BrucePay Bruce Payette (BrucePay) Awaiting requested review from BrucePay

Assignees

See More

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @daxian-dbw @PaulHigin @lukej57