Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview3-27014-02 by bergmeister · Pull Request #7961 · PowerShell/PowerShell

Christoph Bergmeister (bergmeister) · 2018-10-07T10:19:58Z

PR Summary

Upgrading to the latest official preview of .Net Core 2.2.
The update to 2.2 was applied everywhere except for the alpine docker image scripts as they need validation from the MSFT side beforehand.

PR Checklist

… image creation process

…t (build number does not match sdk)

… to problems, they have stopped supporting it, therefore use dotnet test as an alternative xunit/xunit#1675 https://xunit.github.io/releases/2.4

…lease 2h ago

Ilya (iSazonov) · 2018-10-08T04:19:01Z

Perhaps worth the wait. It seems 2.2 branch inspired only by ASP.NET and EntityFramework changes.
Release 2.2.0 is expected in December and PowerShell release 6.2.0 in March. By this moment we will have a 2.2.1 service release. Also most of ordinary changes will be in 3.0 not in servicing releases and 2.2.

Christoph Bergmeister (bergmeister) · 2018-10-08T10:22:10Z

I don't mind if we keep the PR open for longer and accept a later preview or RTM version off .Net Core 2.2.
But I think it is good to have at least a point where we know everything is OK so that it is easier to upgrade later in case there are breaking changes in newer versions, I am happy to keep this branch up to date for the next weeks/months as a tracker for feasibility of an upgrade

Steve Lee (SteveL-MSFT) · 2018-10-08T17:04:19Z

I'm ok with taking .NET Core 2.2 early in our 6.2-preview releases to make sure nothing obvious gets broken and any major issues gives .NET Core time to fix in 2.2.x

Ilya (iSazonov) · 2018-10-09T11:38:22Z

Preview3 is expected in weeks aspnet/Announcements#307.

Travis Plunk (TravisEz13) · 2018-10-09T18:12:07Z

The changes look good. We are verifying with DotNet that 2.2 will be an LTS.

2.2 is not LTS

Travis Plunk (TravisEz13) · 2018-10-09T20:46:50Z

2.2 will not be an LTS. We should probably stay on 2.1 for now. At least until we discuss the impact of this. I like your changes to the xunit tests though. Would you mind submitting a separate PR for those? I can if you want me to.

…o netcore2.2

…o netcore2.2 # Conflicts: # build.psm1 # test/hosting/hosting.tests.csproj

…t code

…o netcore2.2

…o netcore2.2 Conflicts auto-resolved by Tortoise-Git (white space problem only) # Conflicts: # assets/files.wxs

…o netcore2.2

…ccore and sos due to the upgrade from preview2 to preview3

Steve Lee (SteveL-MSFT) · 2018-10-22T21:52:55Z

We're having conversations with .NET Core team in terms of support alignment between PSCore6 and .NET Core. Until that gets resolved, we should only move to LTS versions of .NET Core.

stale · 2018-11-21T22:01:52Z

This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days.
Thank you for your contributions.
Community members are welcome to grab these works.

Andrew (anmenaga) · 2018-11-28T00:28:31Z

Travis Plunk (@TravisEz13) Considering what you and Steve Lee (@SteveL-MSFT) wrote, we probably need to close this PR.

Ilya (iSazonov) · 2018-11-28T03:14:55Z

I see .Net Core 3.0 will come with tons changes, enhancement and additions. We may have to put a lot of effort into upgrading to this version. I think we can close the PR.

Christoph Bergmeister (bergmeister) · 2018-11-28T07:37:43Z

Ok, agreed, I will close the PR but leave the branch in case anyone in the community is interested.

Christoph Bergmeister (bergmeister) added 13 commits October 6, 2018 16:38

try upgrade to 2.2preview2 of .net core

b4687ad

fix version number of sdk (needs to include build number)

56ba0a1

[feature] set runtimeversion and revert changes made to alpine docker…

b961bc2

… image creation process

[feature] Fix NuGet package version of WebListener.csproj test projec…

04f8a7d

…t (build number does not match sdk)

[feature] Fix WiX file components due to newer versions of DLLS

3571629

trigger ci

0a61826

The dotnet-xunit test runner does not work with .Net Core 2.2 and due…

97a67be

… to problems, they have stopped supporting it, therefore use dotnet test as an alternative xunit/xunit#1675 https://xunit.github.io/releases/2.4

I forgot that trx format ix VsTest, not NUnit

9c48a7a

[feature]

91d1c82

[feature] Fix parameter name due to rename

17fab9b

[feature] revert to use xml test logger again

5750e86

[feature] forgot some folder->file reverts

b75514a

[feature] Update Markdig.Signed NuGet package to 0.15.4 due to new re…

e092441

…lease 2h ago

Christoph Bergmeister (bergmeister) requested review from Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners October 7, 2018 10:19

[feature] retrigger CI due to sporadic failure

699afb8

Travis Plunk (TravisEz13) previously approved these changes Oct 9, 2018

View reviewed changes

Travis Plunk (TravisEz13) self-assigned this Oct 9, 2018

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

e8d76e2

…o netcore2.2

Christoph Bergmeister (bergmeister) mentioned this pull request Oct 9, 2018

Use dotnet test instead of dotnet xunit since the xunit runner has been deprecated #7980

Merged

11 tasks

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

d4f2fa4

…o netcore2.2 # Conflicts: # build.psm1 # test/hosting/hosting.tests.csproj

Christoph Bergmeister (bergmeister) added 5 commits October 10, 2018 22:17

fix merge conflict error to have no diff again in the upstreamed xuni…

7de084d

…t code

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

533b0e0

…o netcore2.2

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

96feacf

…o netcore2.2 Conflicts auto-resolved by Tortoise-Git (white space problem only) # Conflicts: # assets/files.wxs

Merge branch 'master' of https://github.com/PowerShell/PowerShell int…

faa0d19

…o netcore2.2

Update to .Net Core 2.2-preview3

fda3fb9

Christoph Bergmeister (bergmeister) requested a review from Paul Higinbotham (PaulHigin) as a code owner October 22, 2018 20:27

[feature] udpate test project version and appveyor cache

8a13d7c

Christoph Bergmeister (bergmeister) changed the title ~~Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview2-26905-02~~ Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview3-27014-02 Oct 22, 2018

[feature] Fix MSI installer by updating to the new version of mscorda…

52de7b7

…ccore and sos due to the upgrade from preview2 to preview3

stale Bot added the Stale label Nov 21, 2018

stale Bot removed the Stale label Nov 28, 2018

Christoph Bergmeister (bergmeister) closed this Nov 28, 2018

Navigation Menu

Uh oh!

Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview3-27014-02 - #7961

Upgrade .Net Core Runtime from 2.1.5 to 2.2.0-preview3-27014-02#7961
Christoph Bergmeister (bergmeister) wants to merge 23 commits into
PowerShell:masterfrom
bergmeister:netcore2.2

Christoph Bergmeister (bergmeister) commented Oct 7, 2018 •

edited

Loading

Uh oh!

Ilya (iSazonov) commented Oct 8, 2018

Uh oh!

Christoph Bergmeister (bergmeister) commented Oct 8, 2018 •

edited

Loading

Uh oh!

Steve Lee (SteveL-MSFT) commented Oct 8, 2018

Uh oh!

Ilya (iSazonov) commented Oct 9, 2018

Uh oh!

Travis Plunk (TravisEz13) commented Oct 9, 2018

Uh oh!

Travis Plunk (TravisEz13) commented Oct 9, 2018

Uh oh!

Steve Lee (SteveL-MSFT) commented Oct 22, 2018

Uh oh!

stale Bot commented Nov 21, 2018

Uh oh!

Andrew (anmenaga) commented Nov 28, 2018

Uh oh!

Ilya (iSazonov) commented Nov 28, 2018

Uh oh!

Christoph Bergmeister (bergmeister) commented Nov 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

Christoph Bergmeister (bergmeister) commented Oct 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Uh oh!

Ilya (iSazonov) commented Oct 8, 2018

Uh oh!

Christoph Bergmeister (bergmeister) commented Oct 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Steve Lee (SteveL-MSFT) commented Oct 8, 2018

Uh oh!

Ilya (iSazonov) commented Oct 9, 2018

Uh oh!

Travis Plunk (TravisEz13) commented Oct 9, 2018

Uh oh!

Travis Plunk (TravisEz13) commented Oct 9, 2018

Uh oh!

Steve Lee (SteveL-MSFT) commented Oct 22, 2018

Uh oh!

stale Bot commented Nov 21, 2018

Uh oh!

Andrew (anmenaga) commented Nov 28, 2018

Uh oh!

Ilya (iSazonov) commented Nov 28, 2018

Uh oh!

Christoph Bergmeister (bergmeister) commented Nov 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Christoph Bergmeister (bergmeister) commented Oct 7, 2018 •

edited

Loading

Christoph Bergmeister (bergmeister) commented Oct 8, 2018 •

edited

Loading