Use params in ImportPSModule() definition - #7933
Conversation
|
Should we add the change to SDK? |
Ilya (iSazonov)
changed the title
Steve Lee (SteveL-MSFT)
left a comment
Steve Lee (SteveL-MSFT)
left a comment
There was a problem hiding this comment.
Can we add a test?
|
Steve Lee (@SteveL-MSFT) Could you please clarify - seems we haven't test for public APIs at all, only for cmdlets and other language objects. I don't even know where to put it. I even think that most likely there should have been unit tests. |
Steve Lee (SteveL-MSFT)
left a comment
Steve Lee (SteveL-MSFT)
left a comment
There was a problem hiding this comment.
Since we don't have existing tests, I won't block this PR. Based on the discussion of concerns of app compat (even though it was agreed it wouldn't be an issue), it would be nice to have some tests to validate.
|
Steve Lee (@SteveL-MSFT) I think we need SDK test set. |
|
Aaron Roney (@twitchax) Could you please check that the change works as expected and we haven't regression? |
|
Awesome. It looks good to me. :) |
|
Aaron Roney (@twitchax) Can you confirm that you can compile your code after the change? |
|
Yeah: totally fine. |
3 participants
PR Summary
Close #6005.
Change method definition
from
public void ImportPSModule(string[] name)to
public void ImportPSModule(params string[] name)PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests